Skip to content

Commit 3240e5a

Browse files
committed
Update CI xfails
1 parent 6400dc8 commit 3240e5a

File tree

3 files changed

+32
-4
lines changed

3 files changed

+32
-4
lines changed

tests/conftest.py

Lines changed: 24 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,8 @@ def pytest_configure(config):
3939

4040
ci_failing_ids = [
4141
# dataframe objects return the interchange dataframe, not a dict, although
42-
# this behaviour might be in the spec soon.
42+
# this is the behaviour that should be in the spec soon.
43+
# See https://github.com/data-apis/dataframe-api/pull/74
4344
"test_dataframe_object.py::test_toplevel_dunder_dataframe[pandas]",
4445
"test_dataframe_object.py::test_toplevel_dunder_dataframe[vaex]",
4546
"test_dataframe_object.py::test_toplevel_dunder_dataframe[modin]",
@@ -54,6 +55,28 @@ def pytest_configure(config):
5455
"test_from_dataframe.py::test_from_dataframe_roundtrip[pandas-vaex]",
5556
"test_from_dataframe.py::test_from_dataframe_roundtrip[modin-vaex]",
5657
"test_from_dataframe.py::test_from_dataframe_roundtrip[vaex-pandas]",
58+
# https://github.com/vaexio/vaex/issues/2093
59+
"test_column_object.py::test_size[vaex]",
60+
# https://github.com/vaexio/vaex/issues/2118
61+
"test_column_object.py::test_dtype[vaex]",
62+
# Raises TypeError as opposed to RuntimeError, although this is the
63+
# behaviour that should be in the spec soon.
64+
# See https://github.com/data-apis/dataframe-api/pull/74
65+
"test_column_object.py::test_describe_categorical[pandas]",
66+
"test_column_object.py::test_describe_categorical[vaex]",
67+
"test_column_object.py::test_describe_categorical[cudf]",
68+
# https://github.com/pandas-dev/pandas/issues/47789
69+
"test_column_object.py::test_null_count[pandas]",
70+
# https://github.com/vaexio/vaex/issues/2120
71+
"test_column_object.py::test_null_count[vaex]",
72+
# https://github.com/modin-project/modin/issues/4687
73+
"test_column_object.py::test_null_count[modin]",
74+
# https://github.com/vaexio/vaex/issues/2121
75+
"test_column_object.py::test_get_chunks[vaex]",
76+
# https://github.com/vaexio/vaex/issues/2122
77+
"test_column_object.py::test_get_buffers[vaex]",
78+
# https://github.com/rapidsai/cudf/issues/11308
79+
"test_column_object.py::test_get_buffers[cudf]",
5780
]
5881

5982

@@ -62,5 +85,3 @@ def pytest_collection_modifyitems(config, items):
6285
for item in items:
6386
if any(id_ in item.nodeid for id_ in ci_failing_ids):
6487
item.add_marker(pytest.mark.xfail())
65-
elif "test_column_object" in item.nodeid:
66-
item.add_marker(pytest.mark.skip("TODO"))

tests/test_column_object.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -125,7 +125,8 @@ def test_null_count(libinfo: LibraryInfo, data: st.DataObject):
125125
null_count = col.null_count
126126
if null_count is not None:
127127
assert isinstance(null_count, int)
128-
assert null_count == sum(np.isnan(mock_col.array))
128+
if mock_col.nominal_dtype != NominalDtype.UTF8: # TODO: test string cols
129+
assert null_count == sum(np.isnan(mock_col.array))
129130

130131

131132
@given(data=st.data())

tests/wrappers.py

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -233,6 +233,11 @@ def modin_frame_equal(df1: mpd.DataFrame, df2: mpd.DataFrame) -> bool:
233233
)
234234
libinfo_params.append(pytest.param(modin_libinfo, id=modin_libinfo.name))
235235

236+
237+
# cuDF
238+
# -----
239+
240+
236241
try:
237242
# cudf has a few issues with upstream pandas that we "fix" with a few hacks
238243
try:
@@ -293,6 +298,7 @@ def cudf_mock_to_toplevel(mock_df: MockDataFrame) -> cudf.DataFrame:
293298
from_dataframe=cudf_from_dataframe,
294299
frame_equal=lambda df1, df2: df1.equals(df2), # NaNs considered equal
295300
toplevel_to_interchange=lambda df: df.__dataframe__(),
301+
exclude_dtypes=[NominalDtype.DATETIME64NS],
296302
)
297303
libinfo_params.append(pytest.param(cupy_libinfo, id=cupy_libinfo.name))
298304

0 commit comments

Comments
 (0)