Skip to content

Commit c2d3f79

Browse files
authored
Merge pull request #455 from rvsia/updatePF4dep
fix(pf4): update patternfly core version
2 parents 0f6c0fe + e4d5f72 commit c2d3f79

File tree

8 files changed

+132
-694
lines changed

8 files changed

+132
-694
lines changed

packages/pf4-component-mapper/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@
2929
"@babel/preset-env": "^7.1.6",
3030
"@babel/preset-react": "^7.0.0",
3131
"@data-driven-forms/react-form-renderer": "*",
32-
"@patternfly/react-core": "^3.134.2",
32+
"@patternfly/react-core": "^3.153.13",
3333
"@patternfly/react-icons": "^3.15.3",
3434
"@semantic-release/git": "^7.0.5",
3535
"@semantic-release/npm": "^5.1.1",
@@ -74,7 +74,7 @@
7474
},
7575
"peerDependencies": {
7676
"@data-driven-forms/react-form-renderer": "^1.11.0",
77-
"@patternfly/react-core": "^3.140.0"
77+
"@patternfly/react-core": "^3.153.13"
7878
},
7979
"dependencies": {
8080
"@patternfly/patternfly-next": "^1.0.175",

packages/pf4-component-mapper/src/tests/__snapshots__/form-template-common.test.js.snap

Lines changed: 15 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -289,7 +289,11 @@ exports[`FormTemplate PF4 Common should add missing buttons if not defined in bu
289289
tabIndex={null}
290290
type="button"
291291
>
292-
Cancel
292+
<span
293+
className="pf-c-button__text"
294+
>
295+
Cancel
296+
</span>
293297
</button>
294298
</Button>
295299
</ComponentWithOuia>
@@ -543,7 +547,11 @@ exports[`FormTemplate PF4 Common should render all controls and with default lab
543547
tabIndex={null}
544548
type="button"
545549
>
546-
Cancel
550+
<span
551+
className="pf-c-button__text"
552+
>
553+
Cancel
554+
</span>
547555
</button>
548556
</Button>
549557
</ComponentWithOuia>
@@ -765,7 +773,11 @@ exports[`FormTemplate PF4 Common should render buttons in correct order 1`] = `
765773
tabIndex={null}
766774
type="button"
767775
>
768-
Cancel
776+
<span
777+
className="pf-c-button__text"
778+
>
779+
Cancel
780+
</span>
769781
</button>
770782
</Button>
771783
</ComponentWithOuia>

packages/pf4-component-mapper/src/tests/tabs.test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ describe('Tabs component', () => {
5151

5252
expect(wrapper.find(PF4Tabs).props().activeKey).toEqual(0);
5353

54-
const secondTabButton = wrapper.find('.pf-c-tabs__button').at(6);
54+
const secondTabButton = wrapper.find('.pf-c-tabs__button').last();
5555
secondTabButton.simulate('click');
5656

5757
expect(wrapper.find(PF4Tabs).props().activeKey).toEqual(1);

packages/pf4-component-mapper/src/tests/wizard/__snapshots__/step-buttons.test.js.snap

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -167,7 +167,11 @@ exports[`<WizardSTepButtons should add custom className to toolbar 1`] = `
167167
tabIndex={null}
168168
type="button"
169169
>
170-
Cancel
170+
<span
171+
className="pf-c-button__text"
172+
>
173+
Cancel
174+
</span>
171175
</button>
172176
</Button>
173177
</ComponentWithOuia>
@@ -345,7 +349,11 @@ exports[`<WizardSTepButtons should render correctly 1`] = `
345349
tabIndex={null}
346350
type="button"
347351
>
348-
Cancel
352+
<span
353+
className="pf-c-button__text"
354+
>
355+
Cancel
356+
</span>
349357
</button>
350358
</Button>
351359
</ComponentWithOuia>

packages/pf4-component-mapper/src/tests/wizard/__snapshots__/wizard.test.js.snap

Lines changed: 20 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1037,7 +1037,11 @@ exports[`<Wizard /> should render correctly and unmount 1`] = `
10371037
tabIndex={null}
10381038
type="button"
10391039
>
1040-
Cancel
1040+
<span
1041+
className="pf-c-button__text"
1042+
>
1043+
Cancel
1044+
</span>
10411045
</button>
10421046
</Button>
10431047
</ComponentWithOuia>
@@ -1674,7 +1678,11 @@ exports[`<Wizard /> should render correctly in modal and unmount 1`] = `
16741678
class="pf-c-button pf-m-link"
16751679
type="button"
16761680
>
1677-
Cancel
1681+
<span
1682+
class="pf-c-button__text"
1683+
>
1684+
Cancel
1685+
</span>
16781686
</button>
16791687
</footer>
16801688
</div>
@@ -1778,7 +1786,11 @@ exports[`<Wizard /> should render correctly in modal and unmount 1`] = `
17781786
class="pf-c-button pf-m-link"
17791787
type="button"
17801788
>
1781-
Cancel
1789+
<span
1790+
class="pf-c-button__text"
1791+
>
1792+
Cancel
1793+
</span>
17821794
</button>
17831795
</footer>
17841796
</div>
@@ -2329,7 +2341,11 @@ exports[`<Wizard /> should render correctly in modal and unmount 1`] = `
23292341
tabIndex={null}
23302342
type="button"
23312343
>
2332-
Cancel
2344+
<span
2345+
className="pf-c-button__text"
2346+
>
2347+
Cancel
2348+
</span>
23332349
</button>
23342350
</Button>
23352351
</ComponentWithOuia>

packages/react-renderer-demo/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@
3232
"@mdx-js/react": "^1.4.5",
3333
"@next/mdx": "^9.3.3",
3434
"@patternfly/patternfly-next": "^1.0.175",
35-
"@patternfly/react-core": "~3.129.3",
35+
"@patternfly/react-core": "^3.153.13",
3636
"@patternfly/react-tokens": "^2.5.1",
3737
"brace": "^0.11.1",
3838
"clsx": "^1.0.4",

packages/react-renderer-demo/src/app/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@
5050
"@mdx-js/react": "^1.4.5",
5151
"@next/mdx": "^9.3.3",
5252
"@patternfly/patternfly-next": "^1.0.175",
53-
"@patternfly/react-core": "~3.134.2",
53+
"@patternfly/react-core": "^3.153.13",
5454
"@patternfly/react-tokens": "^2.5.1",
5555
"babel-plugin-transform-imports": "^2.0.0",
5656
"brace": "^0.11.1",

0 commit comments

Comments
 (0)