Skip to content

Use AddFlagsTLS from helm to add tls cmd options. #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 14, 2019
Merged

Use AddFlagsTLS from helm to add tls cmd options. #109

merged 2 commits into from
Jan 14, 2019

Conversation

cgroschupp
Copy link
Contributor

To enable support for the TLS environment variables (HELM_TLS_ENABLE), I replace the old tls parse logic with the AddFlagsTLS method from Helm.

@cgroschupp
Copy link
Contributor Author

@databus23 Is the pull request ok or do you have suggestions for improvement?

@cgroschupp
Copy link
Contributor Author

Fixes #111

@cgroschupp
Copy link
Contributor Author

Added support for tls-hostname #116

@cgroschupp
Copy link
Contributor Author

@databus23 can you please merge this.

@databus23 databus23 merged commit cf19eeb into databus23:master Jan 14, 2019
@databus23
Copy link
Owner

Thanks and sorry for the long delay

@petergardfjall petergardfjall mentioned this pull request Jan 22, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cgroschupp @databus23