Disable diffing against test hooks by default #119
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
mumoshu
changed the title
mumoshu
approved these changes
Feb 18, 2019
mumoshu
changed the title
|
@mumoshu looks like this broke the tests, no? |
|
Dang! I thought I ran tests but I may not have after I made the final changes. I will take a look today. Is there a reason tests don't get run on every commit? |
|
@databus23 the tests all pass for me. May I ask which tests are failing for you? I just ran |
|
Yeah, those tests are failing and clearly should be based on the change. I don't understand why they do not fail for me... thats so add. Fixing this now. |
regner
added a commit
to regner/helm-diff
that referenced
this pull request
Feb 19, 2019
|
I have opened a PR that should fix the tests. |
databus23
added a commit
that referenced
this pull request
Feb 20, 2019
Fixing tests that were broken with #119
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for #114