Bump github.com/imdario/mergo reference to v0.3.7 #135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For somehow reason, current glide.lock pinned `mergo` to a very old version (dates back to 2014), while github.com/Masterminds/sprig referenced asked for ~v0.3.7 in their glide.yaml which caused build failure. This change bumps Mergo to v0.3.7 to satisfy the dependency requirement Fixes databus23#134 Signed-off-by: Qiu Yu <[email protected]>
|
cc @databus23 |
|
@unicell Hey! Thanks for your contribution. I'm willing to merge this, but the only thing I'm unsure is that, why had this not broken our CI? |
|
@unicell Wow, good catch.. Seems like I was blind. Thanks for clarifying, and your support 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For somehow reason, current glide.lock pinned
mergoto a very oldversion (dates back to 2014), while github.com/Masterminds/sprig
referenced asked for ~v0.3.7 in their glide.yaml which caused build
failure.
This change bumps Mergo to v0.3.7 to satisfy the dependency requirement
Fixes #134
Signed-off-by: Qiu Yu [email protected]