Skip to content

Fix install when HELM_PATH contains a space #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 13, 2019
Merged

Fix install when HELM_PATH contains a space #138

merged 1 commit into from
May 13, 2019

Conversation

mindw
Copy link
Contributor

@mindw mindw commented May 5, 2019

gabdav01@e109198-mac:~/tmp
export HELM_HOME="/tmp/foo me"

gabdav01@e109198-mac:~/tmp
$ helm init --client-only
Creating /tmp/foo me
Creating /tmp/foo me/repository
Creating /tmp/foo me/repository/cache
Creating /tmp/foo me/repository/local
Creating /tmp/foo me/plugins
Creating /tmp/foo me/starters
Creating /tmp/foo me/cache/archive
Creating /tmp/foo me/repository/repositories.yaml
Adding stable repo with URL: https://kubernetes-charts.storage.googleapis.com
Adding local repo with URL: http://127.0.0.1:8879/charts
$HELM_HOME has been configured at /tmp/foo me.
Not installing Tiller due to 'client-only' flag having been set
Happy Helming!

gabdav01@e109198-mac:~/tmp
$ helm plugin install https://github.com/databus23/helm-diff
sh: /tmp/foo: No such file or directory
Error: plugin install hook for "diff" exited with error

gabdav01@e109198-mac:~/tmp

Copy link
Collaborator

@mumoshu mumoshu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thanks for your contribution @mindw ☺️

@mumoshu mumoshu merged commit 065f9eb into databus23:master May 13, 2019
@mindw mindw deleted the patch-1 branch May 13, 2019 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants