Skip to content

Feat: Expose post-renderer flag in the upgrade subcommand #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 6, 2020

Conversation

ruizink
Copy link
Contributor

@ruizink ruizink commented Mar 21, 2020

Fixes #195

@acaire
Copy link

acaire commented Apr 1, 2020

Works perfectly for me with helm v3.1.2:

helm diff upgrade --allow-unreleased --post-renderer /tmp/kustomize redis stable/redis

and /tmp/kustomize as :

#!/bin/bash
cat <&0 > all.yaml
kustomize build . && rm all.yaml

and various yaml:

# kustomization.yaml
resources:
- all.yaml
patches:
- replicas.yaml
# replicas.yaml
apiVersion: apps/v1
kind: StatefulSet
metadata:
  name: redis-slave
spec:
  replicas: 200

@AntonioMeireles
Copy link

@databus23

Hi,

what's holding this specific feature from landing into a formal release ? is there anything the community could help in order to speed up things ;-) ?

thanks in advance!

Copy link
Collaborator

@mumoshu mumoshu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks a lot for your contribution ☺️

@mumoshu mumoshu merged commit 8175484 into databus23:master May 6, 2020
Kirill-Garbar added a commit to Kirill-Garbar/helm-diff that referenced this pull request May 6, 2020
Expose post-renderer flag in the upgrade subcommand (databus23#196)
@AntonioMeireles
Copy link

Thanks all for getting this in ! what a about a new version now to match stock helm's ;-)

All the best!

@ndegory ndegory mentioned this pull request May 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feat] Allow passing post-renderer flag in the upgrade subcommand
4 participants