Add support for Helm 3 --disable-openapi-validation flag #210
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mumoshu
reviewed
May 6, 2020
cmd/helm3.go
Outdated
| @@ -129,6 +129,10 @@ func (d *diffCmd) template(isUpgrade bool) ([]byte, error) { | |||
| flags = append(flags, "--is-upgrade") | |||
| } | |||
|
|
|||
| if disableOpenAPIValidation { | |||
There was a problem hiding this comment.
You should just use if d.disableOpenAPIValidation { instead of passing the extra arg and referencing it
There was a problem hiding this comment.
@mumoshu Thank you for your review. Fixed and resolved conflicts.
Expose post-renderer flag in the upgrade subcommand (databus23#196)
mumoshu
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added disable-openapi-validation helm3 flag support to disable rendered templates validation with the Kubernetes OpenAPI Schema.
helm/helm#7570
It fixes #209