Add --disable-validation for disabling validation against K8s cluster entirely #228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… entirely `--disable-openapi-validation` seems to not work against charts like prometheus-operator because it results in "missing kind" errors due to that it tries to install CRD and CR on first install. That is different than OpenAPI schema validation, which seems rather for detecting invalid fields. The addition of `--disable-validation` disables the manifests validation against the targeted K8s cluster(again, since Helm 3 `helm template --validate` runs validation against the live cluster so it is relevant), so that we can make use of helm-diff even for cases `--disable-openapi-validation` doesn not work. Resolves #183
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--disable-openapi-validationseems to not work against charts like prometheus-operator because it results in "missing kind" errors due to that it tries to install CRD and CR on first install. That is different than OpenAPI schema validation, which seems rather for detecting invalid fields.The addition of
--disable-validationdisables the manifests validation against the targeted K8s cluster(again, since Helm 3helm template --validateruns validation against the live cluster so it is relevant), so that we can make use of helm-diff even for cases--disable-openapi-validationdoesn not work.Resolves #183