add support for strip-trailing-cr #237
Conversation
|
Can somebody merge this request? |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
Can someone please have a look at this? |
cmd/upgrade.go
Outdated
| @@ -270,7 +272,8 @@ func (d *diffCmd) run() error { | |||
| } | |||
| } | |||
|
|
|||
| seenAnyChanges := diff.Manifests(currentSpecs, newSpecs, d.suppressedKinds, d.showSecrets, d.outputContext, d.output, os.Stdout) | |||
| println("#######################################################################################################################################*******************************************************") | |||
There was a problem hiding this comment.
Can we remove this as an irrelevant change?
There was a problem hiding this comment.
Sorry for the delayed response.
Just one comment on a seemingly redundant println. It would be great if you could confirm that it does look like an unnecessary change.
I'll merge this and revert the println addition only after a few days anyway.
Thanks for your contribution @bakito!
|
Hi @mumoshu |
|
@bakito Thanks again for your support! Merging. |
* add support for strip-trailing-cr Fixes databus23#144
* add support for strip-trailing-cr Fixes databus23#144
This PR add support to strip the trailing cr from charts that have been deployed wit different line endings.
See #144