Skip to content

Allow passing the chart repo to helm template #268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 18, 2021

Conversation

aackerman
Copy link
Contributor

@aackerman aackerman commented Mar 12, 2021

Resolves #277

Copy link
Collaborator

@mumoshu mumoshu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, I've never realized helm had this option and I'm entirely unsure when this is supposed to be used, but I learned that it works like:

helm template --repo https://charts.helm.sh/stable envoy

Anyway, we'd better have this to make it consistent with helm template.

LGTM. Thanks a lot for your contribution @aackerman!

@mumoshu mumoshu merged commit d42b177 into databus23:master May 18, 2021
@aackerman
Copy link
Contributor Author

@mumoshu awesome, thanks for getting this merged. This is important for remote repos that aren't already local.

@mumoshu
Copy link
Collaborator

mumoshu commented May 18, 2021

@aackerman Thanks for the info! So, this just frees you from being required to run helm repo add beforehand, right?

@aackerman
Copy link
Contributor Author

@mumoshu yep that's definitely what I'm using it for

@mumoshu
Copy link
Collaborator

mumoshu commented May 19, 2021

@aackerman Got it. Thanks for clarifying ☺️

@dex4er
Copy link

dex4er commented May 19, 2021

Wow, it simplify my deployment scripts too. I had to add special exception in my scripts and do extra and unecessary helm repo add FOO BAR --force-update 1>&2 && helm repo update >/dev/null whenever I run helm diff.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

helm diff doesn't honor --repo option
3 participants