Fix install command #63
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@KernelPanicAUS Thanks for the PR! Just curious but what would be the point of explicitly specifying the version=master here? I was thinking that is the default behavior anyway. |
|
From my experience helm has some issues with git 2.16+ where it can't do a git checkout without specifying the branch. Specifying the branch might appear superfluous, but it makes the barrier to entry lower for folks who are just getting into helm and its plugin ecosystem and saves them from having to research why the copy-pasted command didn't work :) |
|
@KernelPanicAUS Thanks for pointing that out! I slightly remember that I learned about that in the past. So, this would indeed help users like me 😆 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.