feat: Improved diff on apiVersion changes #73
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the apiVersion of a Kind changes, helm-diff detects this as a remove/readd of the whole manifest; this makes it difficult to see the actual changes. This change enables a small heuristic so apiVersion changes like `authentication.k8s.io/v1beta1` -> `authentication.k8s.io/v1` show up as a one-line diff instead of a full-manifest diff, while hopefully not meddling with unexpected apiVersions too badly.
|
@mumoshu @databus23 Would be useful to have this in a release as people are starting to move from older APIs (beta) to the stable ones for Deployments and such; and it kinda freaks them out seeing an add/remove kind of diff when that isn't the case :) |
mumoshu
approved these changes
Jul 25, 2018
mumoshu
reviewed
Jul 25, 2018
| apiBase = strings.Join(sp[:len(sp)-1], "/") | ||
| } | ||
|
|
||
| return fmt.Sprintf("%s, %s, %s (%s)", m.Metadata.Namespace, m.Metadata.Name, m.Kind, apiBase) |
There was a problem hiding this comment.
For anyone interested - This is the heuristic to treat both apiVersions apps/v1 and apps/v1beta as just apps, so that we can give the same manifest name in mapping results for appropriate diffing.
mumoshu
changed the title
mumoshu
changed the title
mumoshu
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #70
When the apiVersion of a Kind changes, helm-diff detects this as a
remove/readd of the whole manifest; this makes it difficult to see the
actual changes. This change enables a small heuristic so apiVersion
changes like
authentication.k8s.io/v1beta1->authentication.k8s.io/v1show up as a one-line diff instead of afull-manifest diff, while hopefully not meddling with unexpected
apiVersions too badly.