Skip to content

add --devel flag support #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 7, 2018
Merged

add --devel flag support #92

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3f35aea
add --devel flag support
sstarcher Sep 7, 2018
972b4c1
Merge branch 'master' into devel_upgrade
sstarcher Sep 7, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions cmd/upgrade.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import (
"strings"

"errors"

"github.com/databus23/helm-diff/diff"
"github.com/databus23/helm-diff/manifest"
"github.com/spf13/cobra"
Expand All @@ -18,6 +19,7 @@ type diffCmd struct {
chartVersion string
client helm.Interface
detailedExitCode bool
devel bool
namespace string // namespace to assume the release to be installed into. Defaults to the current kube config namespace.
valueFiles valueFiles
values []string
Expand Down Expand Up @@ -78,6 +80,7 @@ func newChartCommand() *cobra.Command {
f.BoolVar(&diff.reuseValues, "reuse-values", false, "reuse the last release's values and merge in any new values")
f.BoolVar(&diff.resetValues, "reset-values", false, "reset the values to the ones built into the chart and merge in any new values")
f.BoolVar(&diff.allowUnreleased, "allow-unreleased", false, "enables diffing of releases that are not yet deployed via Helm")
f.BoolVar(&diff.devel, "devel", false, "use development versions, too. Equivalent to version '>0.0.0-0'. If --version is set, this is ignored.")
f.StringArrayVar(&diff.suppressedKinds, "suppress", []string{}, "allows suppression of the values listed in the diff output")
f.IntVarP(&diff.outputContext, "context", "C", -1, "output NUM lines of context around changes")
f.StringVar(&diff.namespace, "namespace", "default", "namespace to assume the release to be installed into")
Expand All @@ -89,6 +92,10 @@ func newChartCommand() *cobra.Command {
}

func (d *diffCmd) run() error {
if d.chartVersion == "" && d.devel {
d.chartVersion = ">0.0.0-0"
}

chartPath, err := locateChartPath(d.chart, d.chartVersion, false, "")
if err != nil {
return err
Expand Down