Skip to content
This repository was archived by the owner on May 17, 2024. It is now read-only.

fix issue 391 incorrect raise, add tests #392

Merged
merged 3 commits into from
Feb 17, 2023
Merged

Conversation

dlawin
Copy link
Contributor

@dlawin dlawin commented Feb 15, 2023

Closes #391

We are inadvertently raising an exception when specifying only prod_database:

Added tests to cover the possible scenarios

Expected (no exception):

dbt_vars_dict = {
            "prod_database": "prod_db",
            "prod_schema": "prod_schema",
            "datasource_id": 1,
        }
dbt_vars_dict = {
            "prod_database": "prod_db",
            "datasource_id": 1,
        }

Exception

dbt_vars_dict = {
            "datasource_id": 1,
        }
dbt_vars_dict = {
            "datasource_id": 1,
            "prod_schema": "prod_schema",
        }

@dlawin dlawin added the bug Something isn't working label Feb 15, 2023
@dlawin dlawin self-assigned this Feb 15, 2023
@nolar nolar merged commit e864c0c into datafold:master Feb 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: must specify both schema and database
2 participants