This repository was archived by the owner on May 17, 2024. It is now read-only.
Squash the redundant abstract classes into their "base" counterparts #714
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nolar
force-pushed
the
simplify-ast-compilation
branch
from
cc66fd4 to
795bb0e
Compare
added 6 commits
September 28, 2023 16:38
nolar
force-pushed
the
simplify-collapse-abcs
branch
from
0f522dd to
7aec378
Compare
dlawin
approved these changes
Sep 28, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is essentially a continuation of squashing the hierarchies in #710, but for a different part — the duplicated classes are now removed and squahed into one.
AbstractDatabase->DatabaseAbstractDialect->BaseDialectAbstractTable->ITableThis should simplify the codebase significantly.
For reference, there is a hand-made inheritance graph before the changes in both PRs:
After the changes, there are only the lower blue classes left. (The mixins are to be removed later; maybe; TBD.)