Fixing startup of the PHP standalone webserver on Windows

mikefero · mikefero · commit 787df82f2591 · 2015-09-09T16:21:25.000-04:00
diff --git a/features/bootstrap/FeatureContext.php b/features/bootstrap/FeatureContext.php
@@ -304,7 +304,10 @@ private function execute(array $env = array())
     private function startWebServer()
     {
         $this->webServerURL = 'http://127.0.0.1:10000';
-        $command = sprintf('exec %s -S "%s"', $this->phpBin, '127.0.0.1:10000');
+        $command = sprintf('%s -S "%s"', $this->phpBin, '127.0.0.1:10000');
+        if (!strtoupper(substr(PHP_OS, 0, 3)) === 'WIN') {
+            $command = 'exec' . $command;
+        }
         if ($this->phpBinOptions) {
             $command = sprintf("%s %s", $command, $this->phpBinOptions);
         }

Original file line number	Diff line number	Diff line change
`@@ -304,7 +304,10 @@ private function execute(array $env = array())`
`304`	`304`	`private function startWebServer()`
`305`	`305`	`{`
`306`	`306`	`$this->webServerURL = 'http://127.0.0.1:10000';`
`307`		`- $command = sprintf('exec %s -S "%s"', $this->phpBin, '127.0.0.1:10000');`
	`307`	`+ $command = sprintf('%s -S "%s"', $this->phpBin, '127.0.0.1:10000');`
	`308`	`+ if (!strtoupper(substr(PHP_OS, 0, 3)) === 'WIN') {`
	`309`	`+ $command = 'exec' . $command;`
	`310`	`+ }`
`308`	`311`	`if ($this->phpBinOptions) {`
`309`	`312`	`$command = sprintf("%s %s", $command, $this->phpBinOptions);`
`310`	`313`	`}`