Skip to content

Commit 65e2fad

Browse files
Juha Heiskanenjuhhei01
authored andcommitted
Fixed uninitialized parameter use at rpl instance allocate.
1 parent 4767dd5 commit 65e2fad

File tree

1 file changed

+1
-17
lines changed

1 file changed

+1
-17
lines changed

source/RPL/rpl_upward.c

Lines changed: 1 addition & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -1008,31 +1008,15 @@ rpl_instance_t *rpl_create_instance(rpl_domain_t *domain, uint8_t instance_id)
10081008
if (!instance) {
10091009
return NULL;
10101010
}
1011+
memset(instance, 0, sizeof(rpl_instance_t));
10111012
ns_list_init(&instance->dodags);
10121013
ns_list_init(&instance->candidate_neighbours);
10131014
ns_list_init(&instance->dao_targets);
10141015
instance->dtsn = rpl_seq_init();
1015-
instance->srh_error_count = 0;
1016-
instance->poison_count = 0;
1017-
instance->repair_dis_timer = 0;
1018-
instance->repair_dis_count = 0;
10191016
instance->last_dao_trigger_time = protocol_core_monotonic_time;
1020-
instance->root_paths_valid = false;
1021-
instance->root_topo_sort_valid = false;
10221017
instance->dao_sequence = rpl_seq_init();
1023-
instance->dao_sequence_in_transit = 0;
1024-
instance->dao_in_transit = false;
1025-
instance->dao_retry_timer = 0;
1026-
instance->dao_attempt = 0;
1027-
instance->delay_dao_timer = 0;
1028-
instance->parent_selection_timer = 0;
1029-
instance->neighbours_changed = false;
1030-
instance->local_repair = false;
10311018
instance->id = instance_id;
10321019
instance->domain = domain;
1033-
instance->current_dodag_version = NULL;
1034-
instance->dio_not_consistent = false;
1035-
instance->of = NULL;
10361020

10371021
ns_list_add_to_start(&domain->instances, instance);
10381022
return instance;

0 commit comments

Comments
 (0)