duplicate address detection fix (ARMmbed#1720)

updated duplicate address detection for roaming case.
fixed a warning in buffer_dyn.c

Author: deepakvenugopal

source/6LoWPAN/Thread/thread_extension_bbr.c

@@ -473,7 +473,7 @@ static int thread_pbbr_bb_qry_cb(int8_t service_id, uint8_t source_address[16],
     }
 
     uint32_t last_transaction_time = protocol_core_monotonic_time - ((thread_pbbr_dua_info_t *)route->info.info)->last_contact_time;
-    uint8_t *ml_eid_ptr = &route->prefix[8];// TODO MLEID needs to be stored in own structure route->info.info and support for dealloc made
+    uint8_t *ml_eid_ptr = ((thread_pbbr_dua_info_t *)route->info.info)->mleid_ptr;
 
     // This address is valid in our MESH
     thread_border_router_bb_ans_send(this, source_address, addr_data_ptr, ml_eid_ptr, last_transaction_time, link_configuration_ptr->name, rloc_ptr);
@@ -515,7 +515,7 @@ static void thread_pbbr_pro_bb_ntf_process(protocol_interface_info_entry_t *cur,
 
 remove_entry:
     tr_info("Remove dua registration for %s", trace_ipv6(addr_data_ptr));
-    ipv6_route_delete(route->prefix, route->prefix_len, cur->id, route->info.next_hop_addr, ROUTE_THREAD_PROXIED_DUA_HOST);
+    ipv6_route_delete(addr_data_ptr, 128, cur->id, NULL, ROUTE_THREAD_PROXIED_DUA_HOST);
     return;
 }
 
@@ -542,7 +542,7 @@ static int thread_pbbr_dua_duplicate_address_detection(int8_t service_id, uint8_
     }
 
     // We have pending request and received answer
-    if (memcmp(ml_eid_ptr,tr_ptr->ml_eid, 8) == 0){
+    if (memcmp(ml_eid_ptr,tr_ptr->ml_eid, 8) != 0 && memcmp(addr_data_ptr, tr_ptr->source_address, 16) == 0){
         // Different ml_eid but same address means duplicate address detected
         thread_resolution_client_address_error(this->interface_id, tr_ptr->source_address, tr_ptr->target_eid, tr_ptr->ml_eid);
         ipv6_neighbour_t *neighbour_entry;
@@ -551,7 +551,7 @@ static int thread_pbbr_dua_duplicate_address_detection(int8_t service_id, uint8_
             tr_debug("Remove from neigh Cache: %s", tr_ipv6(tr_ptr->target_eid));
             ipv6_neighbour_entry_remove(&cur->ipv6_neighbour_cache, neighbour_entry);
         }
-        ipv6_route_delete(route->prefix, route->prefix_len, this->interface_id, route->info.next_hop_addr, ROUTE_THREAD_PROXIED_DUA_HOST);
+        ipv6_route_delete(route->prefix, route->prefix_len, this->interface_id, NULL, ROUTE_THREAD_PROXIED_DUA_HOST);
     }
     return 0;
 }
@@ -855,18 +855,6 @@ static int thread_extension_bbr_dua_cb(int8_t service_id, uint8_t source_address
         thread_border_router_bb_qry_send(this,addr_data_ptr,NULL);
 
     }
-    // TODO
-    // Save RLOC to destination cache with Last transaction time. Should these be made as sticky or should I have own table for these?
-    // send Proactive ND with override
-    // Send PRO_BB.ntf
-
-    // If new registration
-    // Send BB.qry wait DUA_DUPL_CHECK_PERIOD == 1 second. own table needed for pending queries?
-    // Repeat the message?
-    // if response with different EID send error
-    // Store the information
-
-
 
 send_response:
 

source/Core/buffer_dyn.c

@@ -110,7 +110,7 @@ buffer_t *buffer_get_specific(uint16_t headroom, uint16_t size, uint16_t minspac
 #endif
         buf->size = total_size;
     } else {
-        tr_error("buffer_get failed: alloc(%d)", sizeof(buffer_t) + total_size);
+        tr_error("buffer_get failed: alloc(%d)", (int) sizeof(buffer_t) + total_size);
     }
 
     protocol_stats_update(STATS_BUFFER_ALLOC, 1);