Fix GCC_ARM/ARM compiler warnings (ARMmbed#1777)

-'invalid_addr_ptr' may be used uninitialized in this function
-'neigh_entry_ptr' may be used uninitialized in this function
-'buffer' may be used uninitialized in this function
-format '%u' expects argument of type 'unsigned int', but argument 5 has type 'uint32_t
-statement with no effect
-type qualifier specified more than once
-statement is unreachable

Author: Arto Kinnunen

source/6LoWPAN/Thread/thread_common.c

@@ -839,7 +839,7 @@ int thread_attach_ready(protocol_interface_info_entry_t *cur)
         case THREAD_STATE_CONNECTED:
         case THREAD_STATE_CONNECTED_ROUTER:
             return 0;
-            break;
+            /* break; */
         default:
             break;
     }

source/6LoWPAN/Thread/thread_extension_bbr.c

@@ -677,6 +677,7 @@ static int thread_extension_bbr_mlr_cb(int8_t service_id, uint8_t source_address
     uint16_t addr_len;
     uint16_t session_id;
     uint8_t *addr_data_ptr;
+    uint8_t *invalid_addr_ptr = NULL;
     uint32_t timeout_value;
     uint8_t bbr_rloc_addr[16];
     uint8_t bbr_status = THREAD_BBR_STATUS_SUCCESS;
@@ -724,7 +725,6 @@ static int thread_extension_bbr_mlr_cb(int8_t service_id, uint8_t source_address
 
     int16_t remaining = addr_len;
     uint8_t *addr_ptr = addr_data_ptr;
-    uint8_t *invalid_addr_ptr = NULL;
 
     if ( addr_len < 16 ||
          addr_len % 16 != 0 ) {

source/6LoWPAN/adaptation_interface.c

@@ -611,13 +611,13 @@ static fragmenter_tx_entry_t * lowpan_adaptation_tx_process_init(fragmenter_inte
 
 buffer_t * lowpan_adaptation_data_process_tx_preprocess(protocol_interface_info_entry_t *cur, buffer_t *buf)
 {
+    mac_neighbor_table_entry_t *neigh_entry_ptr = NULL;
+
     //Validate is link known and set indirect, datareq and security key id mode
     if (buf->dst_sa.addr_type == ADDR_NONE) {
         goto tx_error_handler;
     }
 
-    mac_neighbor_table_entry_t *neigh_entry_ptr = NULL;
-
     /* If MLE is enabled, we will talk if we have an MLE association */
     if (buf->dst_sa.addr_type == ADDR_802_15_4_LONG ) {
         neigh_entry_ptr = mac_neighbor_table_address_discover(mac_neighbor_info(cur), buf->dst_sa.address + 2, buf->dst_sa.addr_type);

source/MAC/IEEE802_15_4/mac_pd_sap.c

@@ -531,6 +531,7 @@ static bool mac_pd_sap_ack_validation(protocol_interface_rf_mac_setup_s *rf_ptr,
 int8_t mac_pd_sap_data_cb(void *identifier, arm_phy_sap_msg_t *message)
 {
     protocol_interface_rf_mac_setup_s *rf_ptr = (protocol_interface_rf_mac_setup_s*)identifier;
+    mac_pre_parsed_frame_t *buffer = NULL;
 
     if (!rf_ptr || !message ) {
         return -1;
@@ -615,7 +616,7 @@ int8_t mac_pd_sap_data_cb(void *identifier, arm_phy_sap_msg_t *message)
             }
         }
 
-        mac_pre_parsed_frame_t *buffer = mcps_sap_pre_parsed_frame_buffer_get(pd_data_ind->data_ptr, pd_data_ind->data_len);
+        buffer = mcps_sap_pre_parsed_frame_buffer_get(pd_data_ind->data_ptr, pd_data_ind->data_len);
 
         if (!buffer) {
             sw_mac_stats_update(rf_ptr, STAT_MAC_RX_DROP, 0);

source/MAC/IEEE802_15_4/sw_mac.c

@@ -53,7 +53,7 @@ static int8_t ns_sw_mac_api_enable_mcps_ext(mac_api_t *api, mcps_data_indication
 
 static void mlme_req(const mac_api_t* api, mlme_primitive id, const void *data);
 static void mcps_req(const mac_api_t* api, const mcps_data_req_t *data);
-static void mcps_req_ext(const mac_api_t* api, const mcps_data_req_t *data, const const mcps_data_req_ie_list_t *ie_ext, const channel_list_s *asynch_channel_list);
+static void mcps_req_ext(const mac_api_t* api, const mcps_data_req_t *data, const mcps_data_req_ie_list_t *ie_ext, const channel_list_s *asynch_channel_list);
 static void purge_req(const mac_api_t* api, const mcps_purge_t *data);
 static int8_t macext_mac64_address_set( const mac_api_t* api, const uint8_t *mac64);
 static int8_t macext_mac64_address_get( const mac_api_t* api, mac_extended_address_type type, uint8_t *mac64_buf);

source/Service_Libs/mac_neighbor_table/mac_neighbor_table.c

@@ -111,7 +111,7 @@ void mac_neighbor_table_neighbor_timeout_update(mac_neighbor_table_t *table_clas
             if (table_class->user_nud_notify_cb(cur, table_class->table_user_identifier)) {
                 table_class->active_nud_process++;
                 cur->nud_active = true;
-                tr_debug("Nud started index %u : %u time ", cur->index, cur->lifetime);
+                tr_debug("Nud started index %u : %"PRIu32" time ", cur->index, cur->lifetime);
             }
 
         } else {
@@ -176,7 +176,7 @@ void mac_neighbor_table_neighbor_refresh(mac_neighbor_table_t *table_class, mac_
     neighbor_entry->lifetime = life_time;
     neighbor_entry->link_lifetime = life_time;
     if (neighbor_entry->nud_active) {
-        tr_debug("Node index NUD response %u : %u time ", neighbor_entry->index, neighbor_entry->lifetime);
+        tr_debug("Node index NUD response %u : %"PRIu32" time ", neighbor_entry->index, neighbor_entry->lifetime);
         neighbor_entry->nud_active = false;
         table_class->active_nud_process--;
     }

source/Service_Libs/whiteboard/whiteboard.h

@@ -37,7 +37,7 @@ extern uint16_t whiteboard_size_get(void);
 #define whiteboard_rm_entry(id, address)
 #define whiteboard_table_check_address(address) NULL
 #define whiteboard_table_update(address, eui64, status) NULL
-#define whiteboard_interface_unregister_all_address(nwk_id) -1
+#define whiteboard_interface_unregister_all_address(nwk_id)
 #define whiteboard_interface_address_cmp(address) false
 #endif