Remove 1.x tutorials #392
Merged
Remove 1.x tutorials #392
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove 1.x related codes from the workflows * remove haystack_v2 tag
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
julian-risch
approved these changes
Apr 17, 2025
| @@ -26,7 +28,6 @@ def generate_frontmatter(config, tutorial): | |||
| featured_image: /images/tutorial_walkthrough_thumbnail.png | |||
| images: ["/images/tutorial_walkthrough_thumbnail.png"] | |||
| haystack_version: "{tutorial.get("haystack_version", "latest")}" | |||
| haystack_2: {tutorial.get("haystack_2", False)} | |||
There was a problem hiding this comment.
is it really not needed anymore?
There was a problem hiding this comment.
If so, we could also remove from every tutorial in the index.toml the haystack_2 = true?
There was a problem hiding this comment.
We were using that field to put Haystack 2 tag like Featured in the tutorial card. I had removed it from the frontend, this is just a leftover
And you have a point, I'll remove it from index.toml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continues the work in deepset-ai/haystack-home#437