Skip to content

Reword tutorial 36 name and content #395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 18, 2025
Merged

Reword tutorial 36 name and content #395

merged 6 commits into from
Apr 18, 2025

Conversation

bilgeyucel
Copy link
Contributor

No description provided.

@bilgeyucel bilgeyucel requested a review from anakin87 April 17, 2025 13:28
@bilgeyucel bilgeyucel requested a review from a team as a code owner April 17, 2025 13:28
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@bilgeyucel bilgeyucel changed the title Reword tutorial name and content Reword tutorial 36 name and content Apr 17, 2025
@@ -6,13 +6,13 @@
"id": "IR5wivW8THt7"
Copy link
Member

@anakin87 anakin87 Apr 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"inf the form" should be "in the form"


Reply via ReviewNB

@anakin87 anakin87 self-requested a review April 17, 2025 13:39
Copy link
Member

@anakin87 anakin87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from a minor typo, looks good.

I also noticed that you introduced proper RAG in this tutorial (with BM25), which can be reasonable.

Base automatically changed from fix-broken-links to main April 18, 2025 09:46
@bilgeyucel bilgeyucel merged commit 3a7d267 into main Apr 18, 2025
4 checks passed
@bilgeyucel bilgeyucel deleted the agentic-rag branch April 18, 2025 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants