fix(integrations): Handle windows paths with no prefix or backslash prefix in RewriteFrames

Forward slashes are not allowed in Windows paths. This extends RewriteFrames to detect additional Windows-like paths and convert them to use forward slashes.

Author: srubin

packages/integrations/src/rewriteframes.ts

@@ -71,8 +71,10 @@ export class RewriteFrames implements Integration {
     if (!frame.filename) {
       return frame;
     }
-    // Check if the frame filename begins with `/` or a Windows-style prefix such as `C:\`
-    const isWindowsFrame = /^[a-zA-Z]:\\/.test(frame.filename);
+    // Determine if this is a Windows frame by checking for a Windows-style prefix such as `C:\`
+    // or the presence of a backslash without a forward slash (which are not allowed on Windows)
+    const isWindowsFrame = /^[a-zA-Z]:\\/.test(frame.filename) || /^(?!.*\/).*\\.*$/.test(frame.filename);
+    // Check if the frame filename begins with `/`
     const startsWithSlash = /^\//.test(frame.filename);
     if (isWindowsFrame || startsWithSlash) {
       const filename = isWindowsFrame

packages/integrations/test/rewriteframes.test.ts

@@ -7,6 +7,8 @@ let exceptionEvent: Event;
 let exceptionWithoutStackTrace: Event;
 let windowsExceptionEvent: Event;
 let windowsLowerCaseExceptionEvent: Event;
+let windowsExceptionEventWithoutPrefix: Event;
+let windowsExceptionEventWithBackslashPrefix: Event;
 let multipleStacktracesEvent: Event;
 
 describe('RewriteFrames', () => {
@@ -44,6 +46,28 @@ describe('RewriteFrames', () => {
         ],
       },
     };
+    windowsExceptionEventWithoutPrefix = {
+      exception: {
+        values: [
+          {
+            stacktrace: {
+              frames: [{ filename: 'www\\src\\app\\file1.js' }, { filename: 'www\\src\\app\\file2.js' }],
+            },
+          },
+        ],
+      },
+    };
+    windowsExceptionEventWithBackslashPrefix = {
+      exception: {
+        values: [
+          {
+            stacktrace: {
+              frames: [{ filename: '\\www\\src\\app\\file1.js' }, { filename: '\\www\\src\\app\\file2.js' }],
+            },
+          },
+        ],
+      },
+    };
     exceptionWithoutStackTrace = {
       exception: {
         values: [{}],
@@ -121,6 +145,18 @@ describe('RewriteFrames', () => {
       expect(event.exception!.values![0].stacktrace!.frames![0].filename).toEqual('app:///file1.js');
       expect(event.exception!.values![0].stacktrace!.frames![1].filename).toEqual('app:///file2.js');
     });
+
+    it('transforms windowsExceptionEvent frames with no prefix', () => {
+      const event = rewriteFrames.process(windowsExceptionEventWithoutPrefix);
+      expect(event.exception!.values![0].stacktrace!.frames![0].filename).toEqual('app:///file1.js');
+      expect(event.exception!.values![0].stacktrace!.frames![1].filename).toEqual('app:///file2.js');
+    });
+
+    it('transforms windowsExceptionEvent frames with backslash prefix', () => {
+      const event = rewriteFrames.process(windowsExceptionEventWithBackslashPrefix);
+      expect(event.exception!.values![0].stacktrace!.frames![0].filename).toEqual('app:///file1.js');
+      expect(event.exception!.values![0].stacktrace!.frames![1].filename).toEqual('app:///file2.js');
+    });
   });
 
   describe('can use custom root to perform `relative` on filepaths', () => {
@@ -147,6 +183,18 @@ describe('RewriteFrames', () => {
       expect(event.exception!.values![0].stacktrace!.frames![0].filename).toEqual('app:///src/app/file1.js');
       expect(event.exception!.values![0].stacktrace!.frames![1].filename).toEqual('app:///src/app/file2.js');
     });
+
+    it('transforms windowsExceptionEvent frames with no prefix', () => {
+      const event = rewriteFrames.process(windowsExceptionEventWithoutPrefix);
+      expect(event.exception!.values![0].stacktrace!.frames![0].filename).toEqual('app:///src/app/file1.js');
+      expect(event.exception!.values![0].stacktrace!.frames![1].filename).toEqual('app:///src/app/file2.js');
+    });
+
+    it('transforms windowsExceptionEvent frames with backslash prefix', () => {
+      const event = rewriteFrames.process(windowsExceptionEventWithBackslashPrefix);
+      expect(event.exception!.values![0].stacktrace!.frames![0].filename).toEqual('app:///src/app/file1.js');
+      expect(event.exception!.values![0].stacktrace!.frames![1].filename).toEqual('app:///src/app/file2.js');
+    });
   });
 
   describe('can use custom iteratee', () => {