Clear pending decls from Builder in case of errors (ROOT-7295).

Axel-Naumann · devajithvs · commit a866fd29254e · 2025-01-10T10:36:17.000+01:00
diff --git a/clang/lib/CodeGen/ModuleBuilder.cpp b/clang/lib/CodeGen/ModuleBuilder.cpp
@@ -107,6 +107,11 @@ namespace clang {
     }
 
     llvm::Module *ReleaseModule() {
+      // Remove pending etc decls in case of error; the asserts in StartModule()
+      // will rightfully be confused otherwise, as none of the decls were
+      // emitted.
+      if (Diags.hasErrorOccurred())
+        Builder->clear();
       return M.release();
     }
 

Original file line number	Diff line number	Diff line change
`@@ -107,6 +107,11 @@ namespace clang {`
`107`	`107`	`}`
`108`	`108`
`109`	`109`	`llvm::Module *ReleaseModule() {`
	`110`	`+ // Remove pending etc decls in case of error; the asserts in StartModule()`
	`111`	`+ // will rightfully be confused otherwise, as none of the decls were`
	`112`	`+ // emitted.`
	`113`	`+ if (Diags.hasErrorOccurred())`
	`114`	`+ Builder->clear();`
`110`	`115`	`return M.release();`
`111`	`116`	`}`
`112`	`117`