Do not collect DeleteExprs over incremental end-of-TUs (speedup).

Axel-Naumann · devajithvs · commit ed069911a8bf · 2025-01-10T10:36:17.000+01:00
diff --git a/clang/lib/Sema/Sema.cpp b/clang/lib/Sema/Sema.cpp
@@ -1451,14 +1451,15 @@ void Sema::ActOnEndOfTranslationUnit() {
   }
 
   if (!Diags.isIgnored(diag::warn_mismatched_delete_new, SourceLocation())) {
-    if (ExternalSource)
+    if (ExternalSource && !PP.isIncrementalProcessingEnabled())
       ExternalSource->ReadMismatchingDeleteExpressions(DeleteExprs);
     for (const auto &DeletedFieldInfo : DeleteExprs) {
       for (const auto &DeleteExprLoc : DeletedFieldInfo.second) {
         AnalyzeDeleteExprMismatch(DeletedFieldInfo.first, DeleteExprLoc.first,
                                   DeleteExprLoc.second);
       }
     }
+    DeleteExprs.clear();
   }
 
   AnalysisWarnings.IssueWarnings(Context.getTranslationUnitDecl());

Original file line number	Diff line number	Diff line change
`@@ -1451,14 +1451,15 @@ void Sema::ActOnEndOfTranslationUnit() {`
`1451`	`1451`	`}`
`1452`	`1452`
`1453`	`1453`	`if (!Diags.isIgnored(diag::warn_mismatched_delete_new, SourceLocation())) {`
`1454`		`- if (ExternalSource)`
	`1454`	`+ if (ExternalSource && !PP.isIncrementalProcessingEnabled())`
`1455`	`1455`	`ExternalSource->ReadMismatchingDeleteExpressions(DeleteExprs);`
`1456`	`1456`	`for (const auto &DeletedFieldInfo : DeleteExprs) {`
`1457`	`1457`	`for (const auto &DeleteExprLoc : DeletedFieldInfo.second) {`
`1458`	`1458`	`AnalyzeDeleteExprMismatch(DeletedFieldInfo.first, DeleteExprLoc.first,`
`1459`	`1459`	`DeleteExprLoc.second);`
`1460`	`1460`	`}`
`1461`	`1461`	`}`
	`1462`	`+ DeleteExprs.clear();`
`1462`	`1463`	`}`
`1463`	`1464`
`1464`	`1465`	`AnalysisWarnings.IssueWarnings(Context.getTranslationUnitDecl());`