Skip to content

Commit af0bba0

Browse files
committed
reset wiznet at network deinitialize adafruit#1800
1 parent e00a702 commit af0bba0

File tree

5 files changed

+27
-8
lines changed

5 files changed

+27
-8
lines changed

shared-bindings/wiznet/wiznet5k.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -204,6 +204,7 @@ const mod_network_nic_type_t mod_network_nic_type_wiznet5k = {
204204
.settimeout = wiznet5k_socket_settimeout,
205205
.ioctl = wiznet5k_socket_ioctl,
206206
.timer_tick = wiznet5k_socket_timer_tick,
207+
.deinit = wiznet5k_socket_deinit,
207208
};
208209

209210
#endif // MICROPY_PY_WIZNET5K

shared-module/network/__init__.c

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,11 @@ void network_module_init(void) {
4343
}
4444

4545
void network_module_deinit(void) {
46+
for (mp_uint_t i = 0; i < MP_STATE_PORT(mod_network_nic_list).len; i++) {
47+
mp_obj_t nic = MP_STATE_PORT(mod_network_nic_list).items[i];
48+
mod_network_nic_type_t *nic_type = (mod_network_nic_type_t*)mp_obj_get_type(nic);
49+
if (nic_type->deinit != NULL) nic_type->deinit(nic);
50+
}
4651
mp_obj_list_set_len(&MP_STATE_PORT(mod_network_nic_list), 0);
4752
}
4853

shared-module/network/__init__.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -62,6 +62,7 @@ typedef struct _mod_network_nic_type_t {
6262
int (*settimeout)(struct _mod_network_socket_obj_t *socket, mp_uint_t timeout_ms, int *_errno);
6363
int (*ioctl)(struct _mod_network_socket_obj_t *socket, mp_uint_t request, mp_uint_t arg, int *_errno);
6464
void (*timer_tick)(struct _mod_network_socket_obj_t *socket);
65+
void (*deinit)(struct _mod_network_socket_obj_t *socket);
6566
} mod_network_nic_type_t;
6667

6768
typedef struct _mod_network_socket_obj_t {

shared-module/wiznet/wiznet5k.c

Lines changed: 19 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -357,6 +357,23 @@ bool wiznet5k_check_dhcp(void) {
357357
return wiznet5k_obj.dhcp_socket >= 0;
358358
}
359359

360+
void wiznet5k_reset(void) {
361+
if (wiznet5k_obj.rst.pin) {
362+
// hardware reset if using RST pin
363+
common_hal_digitalio_digitalinout_set_value(&wiznet5k_obj.rst, 0);
364+
mp_hal_delay_us(10); // datasheet says 2us
365+
common_hal_digitalio_digitalinout_set_value(&wiznet5k_obj.rst, 1);
366+
mp_hal_delay_ms(150); // datasheet says 150ms
367+
} else {
368+
// otherwise, software reset
369+
wizchip_sw_reset();
370+
}
371+
}
372+
373+
void wiznet5k_socket_deinit(mod_network_socket_obj_t *socket) {
374+
wiznet5k_reset();
375+
}
376+
360377
/// Create and return a WIZNET5K object.
361378
mp_obj_t wiznet5k_create(mp_obj_t spi_in, mp_obj_t cs_in, mp_obj_t rst_in) {
362379

@@ -381,14 +398,8 @@ mp_obj_t wiznet5k_create(mp_obj_t spi_in, mp_obj_t cs_in, mp_obj_t rst_in) {
381398
common_hal_digitalio_digitalinout_construct(&wiznet5k_obj.cs, cs_in);
382399
common_hal_digitalio_digitalinout_switch_to_output(&wiznet5k_obj.cs, 1, DRIVE_MODE_PUSH_PULL);
383400

384-
if (rst_in) {
385-
common_hal_digitalio_digitalinout_construct(&wiznet5k_obj.rst, rst_in);
386-
common_hal_digitalio_digitalinout_switch_to_output(&wiznet5k_obj.rst, 1, DRIVE_MODE_PUSH_PULL);
387-
common_hal_digitalio_digitalinout_set_value(&wiznet5k_obj.rst, 0);
388-
mp_hal_delay_us(10); // datasheet says 2us
389-
common_hal_digitalio_digitalinout_set_value(&wiznet5k_obj.rst, 1);
390-
mp_hal_delay_ms(160); // datasheet says 150ms
391-
}
401+
if (rst_in) common_hal_digitalio_digitalinout_construct(&wiznet5k_obj.rst, rst_in);
402+
wiznet5k_reset();
392403

393404
reg_wizchip_cris_cbfunc(wiz_cris_enter, wiz_cris_exit);
394405
reg_wizchip_cs_cbfunc(wiz_cs_select, wiz_cs_deselect);

shared-module/wiznet/wiznet5k.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,7 @@ int wiznet5k_socket_setsockopt(mod_network_socket_obj_t *socket, mp_uint_t level
5757
int wiznet5k_socket_settimeout(mod_network_socket_obj_t *socket, mp_uint_t timeout_ms, int *_errno);
5858
int wiznet5k_socket_ioctl(mod_network_socket_obj_t *socket, mp_uint_t request, mp_uint_t arg, int *_errno);
5959
void wiznet5k_socket_timer_tick(mod_network_socket_obj_t *socket);
60+
void wiznet5k_socket_deinit(mod_network_socket_obj_t *socket);
6061
mp_obj_t wiznet5k_socket_disconnect(mp_obj_t self_in);
6162
mp_obj_t wiznet5k_create(mp_obj_t spi_in, mp_obj_t cs_in, mp_obj_t rst_in);
6263

0 commit comments

Comments
 (0)