Merge branch 'master' of https://github.com/Azure/azure-powershell into nullreferenceexception-in-AzAccounts#10292

Author: VeryEarly

.azure-pipelines/powershell-core.yml

@@ -1,8 +1,8 @@
 variables:
   WindowsName: windows
-  WindowsImage: VS2017-Win2016
+  WindowsImage: vs2017-win2016
   LinuxName: linux
-  LinuxImage: Ubuntu-18.04
+  LinuxImage: ubuntu-18.04
   MacOSName: macOS
   MacOSImage: macOS-10.13
   TestFramework: netcoreapp2.1

src/Cdn/Cdn.Test/Cdn.Test.csproj

@@ -11,7 +11,7 @@
   </PropertyGroup>
 
   <ItemGroup>
-    <PackageReference Include="Microsoft.Azure.Management.Cdn" Version="4.2.2-preview" />
+    <PackageReference Include="Microsoft.Azure.Management.Cdn" Version="4.2.4-preview" />
   </ItemGroup>
 
 </Project>

src/Cdn/Cdn.Test/ScenarioTests/EndpointTests.cs

@@ -35,6 +35,13 @@ public void TestEndpointCrudAndAction()
             TestController.NewInstance.RunPowerShellTest(_logger, "Test-EndpointCrudAndAction");
         }
 
+        [Fact]
+        [Trait(Category.AcceptanceType, Category.CheckIn)]
+        public void TestEndpointCreateWithRulesEngine()
+        {
+            TestController.NewInstance.RunPowerShellTest(_logger, "Test-EndpointCreateWithRulesEngine");
+        }
+
         [Fact]
         [Trait(Category.AcceptanceType, Category.CheckIn)]
         public void TestEndpointCrudAndActionWithPiping()

src/Cdn/Cdn.Test/ScenarioTests/EndpointTests.ps1

@@ -70,6 +70,53 @@ function Test-EndpointCrudAndAction
     Remove-AzResourceGroup -Name $resourceGroup.ResourceGroupName -Force
 }
 
+<#
+.SYNOPSIS
+Create ENdpoint with RulesEngine config
+#>
+function Test-EndpointCreateWithRulesEngine
+{
+    $profileName = getAssetName
+    $resourceGroup = TestSetup-CreateResourceGroup
+    $resourceLocation = "EastUS"
+    $profileSku = "Standard_Microsoft"
+    $createdProfile = New-AzCdnProfile -ProfileName $profileName -ResourceGroupName $resourceGroup.ResourceGroupName -Location $resourceLocation -Sku $profileSku
+
+    $endpointName = getAssetName
+    $originName = getAssetName
+    $originHostName = "www.microsoft.com"
+
+    $nameAvailability = Get-AzCdnEndpointNameAvailability -EndpointName $endpointName
+    Assert-True{$nameAvailability.NameAvailable}
+
+	$description = 'Sample delivery policy'
+    $cond1 = New-AzCdnDeliveryRuleCondition -MatchVariable IsDevice -Operator Equal -MatchValue "Desktop"
+    $action1 = New-AzCdnDeliveryRuleAction -SourcePattern "/abc" -Destination "/def" -PreservePath
+    $action2 = New-AzCdnDeliveryRuleAction -QueryStringBehavior ExcludeAll -QueryParameter "abc","def"
+    $action3 = New-AzCdnDeliveryRuleAction -QueryStringBehavior IncludeAll
+    $redirect = New-AzCdnDeliveryRuleAction -RedirectType Found -DestinationProtocol MatchRequest
+    $rule0 = New-AzCdnDeliveryRule -Name "EmptyCondition" -Order 0 -Action $redirect,$action3
+    $rule1 = New-AzCdnDeliveryRule -Name "Rule1" -Order 1 -Condition $cond1 -Action $action1,$action2
+    $deliverypolicy = New-AzCdnDeliveryPolicy -Description $description -Rule $rule0,$rule1
+
+    $createdEndpoint = New-AzCdnEndpoint -EndpointName $endpointName -ProfileName $profileName -ResourceGroupName $resourceGroup.ResourceGroupName -Location $resourceLocation -OriginName $originName -OriginHostName $originHostName -DeliveryPolicy $deliveryPolicy
+	Assert-AreEqual $description $createdEndpoint.DeliveryPolicy.Description
+    Assert-AreEqual $endpointName $createdEndpoint.Name
+    Assert-AreEqual $deliverypolicy.Count $createdEndpoint.DeliveryPolicy.Count
+    Assert-AreEqual $profileName $createdEndpoint.ProfileName
+    Assert-AreEqual $resourceGroup.ResourceGroupName $createdEndpoint.ResourceGroupName
+    Assert-AreEqual $originName $createdEndpoint.Origins[0].Name
+    Assert-AreEqual $originHostName $createdEndpoint.Origins[0].HostName
+
+    $endpointRemoved = Remove-AzCdnEndpoint -EndpointName $endpointName -ProfileName $profileName -ResourceGroupName $resourceGroup.ResourceGroupName -PassThru -Force
+    Assert-True{$endpointRemoved}
+
+    Assert-ThrowsContains { Get-AzCdnEndpoint -EndpointName $endpointName -ProfileName $profileName -ResourceGroupName $resourceGroup.ResourceGroupName } "NotFound"
+
+    Remove-AzResourceGroup -Name $resourceGroup.ResourceGroupName -Force
+}
+
+
 <#
 .SYNOPSIS
 Endpoint cycle with piping

src/Cdn/Cdn.Test/SessionRecords/Microsoft.Azure.Commands.Cdn.Test.ScenarioTests.ScenarioTest.EndpointTests/TestEndpointCreateWithRulesEngine.json

@@ -11,7 +11,7 @@
   </PropertyGroup>
 
   <ItemGroup>
-    <PackageReference Include="Microsoft.Azure.Management.Cdn" Version="4.2.2-preview" />
+    <PackageReference Include="Microsoft.Azure.Management.Cdn" Version="4.2.4-preview" />
   </ItemGroup>
 
 </Project>

src/Cdn/Cdn/Cdn.csproj

@@ -19,6 +19,8 @@
 -->
 
 ## Upcoming Release
+* Introduced UrlRewriteAction and CacheKeyQueryStringAction to RulesEngine.
+* Fixed several bugs like missing "Selector" Input in New-AzDeliveryRuleCondition cmdlet.
 
 ## Version 1.3.1
 * Fixed miscellaneous typos across module

src/Cdn/Cdn/ChangeLog.md

@@ -36,6 +36,8 @@ public class AzureCdnCmdletBase : AzureRMCmdlet
         public const string CacheExpirationActionParameterSet = "CacheExpirationActionParameterSet";
         public const string HeaderActionParameterSet = "HeaderActionParameterSet";
         public const string UrlRedirectActionParameterSet = "UrlRedirectActionParameterSet";
+        public const string CacheKeyQueryStringActionParameterSet = "CacheKeyQueryStringActionParameterSet";
+        public const string UrlRewriteActionParameterSet = "UrlRewriteActionParameterSet";
 
 
         /// <summary>

src/Cdn/Cdn/Common/AzureCdnCmdletBase.cs

@@ -34,14 +34,17 @@ public class NewAzCdnDeliveryRuleCondition : AzureCdnCmdletBase
         [Parameter(Mandatory = true, HelpMessage = "Match variable of the condition.")]
         [ValidateNotNullOrEmpty]
         [PSArgumentCompleter("RemoteAddress", "RequestMethod", "QueryString", "PostArgs", "RequestUri",
-            "RequestHeader", "RequestBody", "RequestScheme", "UrlPath", "UrlFileExtension", "UrlFileName", "IsDevice")]
+            "RequestHeader", "RequestBody", "RequestScheme", "UrlPath", "UrlFileExtension", "UrlFileName", "IsDevice", "Cookies", "HttpVersion")]
         public string MatchVariable { get; set; }
 
         [Parameter(Mandatory = true, HelpMessage = "Describes operator to be matched")]
         [ValidateNotNullOrEmpty]
         [PSArgumentCompleter("Any", "IPMatch", "GeoMatch", "Equal", "Contains","LessThan", "GreaterThan",
             "LessThanOrEqual", "GreaterThanOrEqual", "BeginsWith", "EndsWith", "Wildcard")]
         public string Operator { get; set; }
+        
+        [Parameter(Mandatory = false, HelpMessage = "Name of Selector to be matched")]
+        public string Selector { get; set; }
 
         [Parameter(Mandatory = true, HelpMessage = "List of possible match values.")]
         public string[] MatchValue { get; set; }
@@ -59,6 +62,7 @@ public override void ExecuteCmdlet()
             {
                 MatchVariable = MatchVariable,
                 Operator = Operator,
+                Selector = Selector,
                 MatchValue = MatchValue,
                 NegateCondition = NegateCondition,
                 Transfroms = Transform == null? null : new List<string> { Transform }

src/Cdn/Cdn/Endpoint/NewAzCdnDdliveryRuleCondition.cs

@@ -83,6 +83,22 @@ public class NewAzCdnDeliveryRuleAction : AzureCdnCmdletBase
         [ValidateNotNullOrEmpty]
         public string CustomFragment { get; set; }
 
+        [Parameter(Mandatory = true, HelpMessage = "QueryString behavior for the requests", ParameterSetName = CacheKeyQueryStringActionParameterSet)]
+        [PSArgumentCompleter("Include", "IncludeAll", "Exclude", "ExcludeAll")]
+        [ValidateNotNullOrEmpty]
+        public string QueryStringBehavior { get; set; }
+
+        [Parameter(Mandatory = false, HelpMessage = "Query parameters to include or exclude (comma separated).", ParameterSetName = CacheKeyQueryStringActionParameterSet)]
+        public string[] QueryParameter { get; set; }
+
+        [Parameter(Mandatory = true, HelpMessage = "Define a request URI pattern that identifies the type of requests that may be rewritten. If value is blank, all strings are matched.", ParameterSetName = UrlRewriteActionParameterSet)]
+        public string SourcePattern { get; set; }
+
+        [Parameter(Mandatory = true, HelpMessage = "Define the relative URL to which the above requests will be rewritten by.", ParameterSetName = UrlRewriteActionParameterSet)]
+        public string Destination { get; set; }
+
+        [Parameter(Mandatory = false, HelpMessage = "Whether to preserve unmatched path.", ParameterSetName = UrlRewriteActionParameterSet)]
+        public SwitchParameter PreservePath { get; set; }
 
         public override void ExecuteCmdlet()
         {
@@ -120,6 +136,32 @@ public override void ExecuteCmdlet()
                    CustomFragment = CustomFragment
                 };
             }
+            else if (ParameterSetName == CacheKeyQueryStringActionParameterSet)
+            {
+                if ((QueryStringBehavior == "Exclude" || QueryStringBehavior == "Include") && QueryParameter == null)
+                {
+                    throw new PSArgumentException("QueryParameter cannot be empty when QueryStringBehavior is {0}", QueryStringBehavior);
+                }
+                else if (QueryStringBehavior == "ExcludeAll" || QueryStringBehavior == "IncludeAll")
+                {
+                    QueryParameter = null;
+                }
+
+                deliveryRuleAction = new PSDeliveryRuleCacheKeyQueryStringAction
+                {
+                    QueryStringBehavior = QueryStringBehavior,
+                    QueryParameter = QueryParameter == null? string.Empty : string.Join(",", QueryParameter)
+                };
+            }
+            else if (ParameterSetName == UrlRewriteActionParameterSet)
+            {
+                deliveryRuleAction = new PSDeliveryRuleUrlRewriteAction
+                {
+                    SourcePattern = SourcePattern,
+                    Destination = Destination,
+                    PreservePath = PreservePath
+                };
+            }
             else
             {
                 deliveryRuleAction = new PSDeliveryRuleAction();

src/Cdn/Cdn/Endpoint/NewAzCdnDeliveryRuleAction.cs

@@ -43,27 +43,34 @@ private void SetEndpoint()
         {
             var resourceGroupName = CdnEndpoint.ResourceGroupName;
             var profileName = CdnEndpoint.ProfileName;
+            try
+            {
+                var endpoint = CdnManagementClient.Endpoints.Update(
+                    resourceGroupName,
+                    profileName,
+                    CdnEndpoint.Name,
+                    new EndpointUpdateParameters(
+                        CdnEndpoint.Tags.ToDictionaryTags(),
+                        CdnEndpoint.OriginHostHeader,
+                        CdnEndpoint.OriginPath,
+                        CdnEndpoint.ContentTypesToCompress.ToList(),
+                        CdnEndpoint.IsCompressionEnabled,
+                        CdnEndpoint.IsHttpAllowed,
+                        CdnEndpoint.IsHttpsAllowed,
+                        (QueryStringCachingBehavior)Enum.Parse(typeof(QueryStringCachingBehavior), CdnEndpoint.QueryStringCachingBehavior.ToString()),
+                        CdnEndpoint.OptimizationType,
+                        CdnEndpoint.ProbePath,
+                        CdnEndpoint.GeoFilters.Select(g => g.ToSdkGeoFilter()).ToList(),
+                        CdnEndpoint.DeliveryPolicy?.ToSdkDeliveryPolicy()));
 
-            var endpoint = CdnManagementClient.Endpoints.Update(
-                resourceGroupName,
-                profileName,
-                CdnEndpoint.Name,
-                new EndpointUpdateParameters(
-                    CdnEndpoint.Tags.ToDictionaryTags(),
-                    CdnEndpoint.OriginHostHeader,
-                    CdnEndpoint.OriginPath,
-                    CdnEndpoint.ContentTypesToCompress.ToList(),
-                    CdnEndpoint.IsCompressionEnabled,
-                    CdnEndpoint.IsHttpAllowed,
-                    CdnEndpoint.IsHttpsAllowed,
-                    (QueryStringCachingBehavior)Enum.Parse(typeof(QueryStringCachingBehavior), CdnEndpoint.QueryStringCachingBehavior.ToString()),
-                    CdnEndpoint.OptimizationType,
-                    CdnEndpoint.ProbePath,
-                    CdnEndpoint.GeoFilters.Select(g => g.ToSdkGeoFilter()).ToList(),
-                    CdnEndpoint.DeliveryPolicy?.ToSdkDeliveryPolicy()));
-
-            WriteVerbose(Resources.Success);
-            WriteObject(endpoint.ToPsEndpoint());
+                WriteVerbose(Resources.Success);
+                WriteObject(endpoint.ToPsEndpoint());
+            }
+            catch (Microsoft.Azure.Management.Cdn.Models.ErrorResponseException e)
+            {
+                throw new PSArgumentException(string.Format("Error response received.Error Message: '{0}'",
+                                     e.Response.Content));
+            }
         }
     }
 }