Merge pull request Azure#10813 from dingmeng-xue/detect-break

Fixed Static Analysis issue

Author: isra-fel

tools/StaticAnalysis/BreakingChangeAnalyzer/BreakingChangeAnalyzer.cs

@@ -131,11 +131,14 @@ public void Analyze(
                     var parentDirectory = Directory.GetParent(psd1).FullName;
                     var psd1FileName = Path.GetFileName(psd1);
                     var powershell = PowerShell.Create();
-                    powershell.AddScript("Import-LocalizedData -BaseDirectory " + parentDirectory +
-                                         " -FileName " + psd1FileName +
-                                         " -BindingVariable ModuleMetadata; $ModuleMetadata.NestedModules; $ModuleMetadata.RequiredModules | % { $_[\"ModuleName\"] };");
+
+                    var script = $"Import-LocalizedData -BaseDirectory {parentDirectory} -FileName {psd1FileName} -BindingVariable ModuleMetadata;";
+                    powershell.AddScript($"{script} $ModuleMetadata.NestedModules;");
                     var cmdletResult = powershell.Invoke();
-                    var nestedModules = cmdletResult.Where(c => c.ToString().StartsWith(".")).Select(c => c.ToString().Substring(2));
+                    var nestedModules = cmdletResult.Select(c => c.ToString()).Select(c => (c.StartsWith(".") ? c.Substring(2) : c)).ToList();
+
+                    powershell.AddScript($"{script} $ModuleMetadata.RequiredModules | % {{ $_[\"ModuleName\"] }};");
+                    cmdletResult = powershell.Invoke();
                     var requiredModules = cmdletResult.Where(c => !c.ToString().StartsWith(".")).Select(c => c.ToString()).ToList();
 
                     if (!nestedModules.Any()) continue;

tools/VersionController/Models/VersionMetadataHelper.cs

@@ -8,6 +8,7 @@
 using System.Reflection;
 using System.Text.RegularExpressions;
 using Tools.Common.Helpers;
+using Tools.Common.Issues;
 using Tools.Common.Loaders;
 using Tools.Common.Loggers;
 using Tools.Common.Models;
@@ -255,6 +256,7 @@ public Version GetVersionBumpForCommonCode()
         /// <returns>Version enum representing the version bump to be applied.</returns>
         public Version GetVersionBumpUsingSerialized(bool serialize = true)
         {
+            Console.WriteLine("Comparing the cmdlet assumblies with metadata from JSON file...");
             var outputModuleManifestPath = _fileHelper.OutputModuleManifestPath;
             var outputModuleDirectory = _fileHelper.OutputModuleDirectory;
             var outputDirectories = _fileHelper.OutputDirectories;
@@ -311,6 +313,14 @@ public Version GetVersionBumpUsingSerialized(bool serialize = true)
                     CheckBreakingChangesInModules(oldModuleMetadata, newModuleMetadata, issueLogger);
                     if (issueLogger.Records.Any())
                     {
+                        var currentColor = Console.ForegroundColor;
+                        Console.ForegroundColor = ConsoleColor.Yellow;
+                        Console.WriteLine($"Detected below {issueLogger.Records.Count} breack change(s):");
+                        foreach (IReportRecord record in issueLogger.Records)
+                        {
+                            Console.WriteLine(((BreakingChangeIssue)record).Target + " " + record.ProblemId + " " + record.Description);
+                        }
+                        Console.ForegroundColor = currentColor;
                         tempVersionBump = Version.MAJOR;
                     }
                     else if (!oldModuleMetadata.Equals(newModuleMetadata))
@@ -349,6 +359,7 @@ public Version GetVersionBumpUsingSerialized(bool serialize = true)
         /// <returns>Version enum representing the version bump to be applied.</returns>
         public Version GetVersionBumpUsingGallery()
         {
+            Console.WriteLine("Comparing the cmdlet assumblies with seemblies in the saved gallery folder...");
             var outputModuleManifestPath = _fileHelper.OutputModuleManifestPath;
             var outputModuleDirectory = _fileHelper.OutputModuleDirectory;
             var outputDirectories = _fileHelper.OutputDirectories;