Merge pull request Azure#10303 from VeryEarly/nullreferenceexception-in-AzAccounts#10292

Nullreferenceexception in az accounts#10292

Author: isra-fel

src/Accounts/Accounts/ChangeLog.md

@@ -18,6 +18,7 @@
         - Additional information about change #1
 -->
 ## Upcoming Release
+* Fix Get-AzTenant/Get-AzDefault/Set-AzDefault throw NullReferenceException when not login
 
 ## Version 1.7.3
 * Open Azure PowerShell survey page in `Send-Feedback` [#11020]

src/Accounts/Accounts/Default/ClearAzureRmDefault.cs

@@ -46,7 +46,7 @@ public override void ExecuteCmdlet()
                 throw new Exception("Default Resource Group cannot be set on CloudShell");
             }
 
-            IAzureContext context = AzureRmProfileProvider.Instance.Profile.DefaultContext;
+            IAzureContext context = DefaultContext;
             // If no parameters are specified, clear all defaults
             if (!ResourceGroup)
             {

src/Accounts/Accounts/Default/GetAzureRmDefault.cs

@@ -37,7 +37,7 @@ public class GetAzureRMDefaultCommand : AzureRMCmdlet
 
         public override void ExecuteCmdlet()
         {
-            IAzureContext context = AzureRmProfileProvider.Instance.Profile.DefaultContext;
+            IAzureContext context = DefaultContext;
             IResourceManagementClient client = AzureSession.Instance.ClientFactory.CreateCustomArmClient<ResourceManagementClient>(
                                     context.Environment.GetEndpointAsUri(AzureEnvironment.Endpoint.ResourceManager),
                                     AzureSession.Instance.AuthenticationFactory.GetServiceClientCredentials(context, AzureEnvironment.Endpoint.ResourceManager),

src/Accounts/Accounts/Default/SetAzureRMDefault.cs

@@ -50,7 +50,7 @@ public override void ExecuteCmdlet()
                 throw new Exception("Default Resource Group cannot be set on CloudShell");
             }
 
-            IAzureContext context = AzureRmProfileProvider.Instance.Profile.DefaultContext;
+            IAzureContext context = DefaultContext;
             IResourceManagementClient resourceManagementclient = AzureSession.Instance.ClientFactory.CreateCustomArmClient<ResourceManagementClient>(
                                 context.Environment.GetEndpointAsUri(AzureEnvironment.Endpoint.ResourceManager),
                                 AzureSession.Instance.AuthenticationFactory.GetServiceClientCredentials(context, AzureEnvironment.Endpoint.ResourceManager),

src/Accounts/Accounts/Models/RMProfileClient.cs

@@ -41,6 +41,18 @@ public class RMProfileClient
         private IAzureTokenCache _cache;
         public Action<string> WarningLog;
 
+        private IAzureContext DefaultContext
+        {
+            get
+            {
+                if(_profile == null || _profile.DefaultContext == null || _profile.DefaultContext.Account == null)
+                {
+                    throw new PSInvalidOperationException(ResourceMessages.RunConnectAccount);
+                }
+                return _profile.DefaultContext;
+            }
+        }
+
         public RMProfileClient(IProfileOperations profile)
         {
             _profile = profile;
@@ -368,7 +380,7 @@ public List<AzureTenant> ListTenants(string tenant = "")
                 return new List<AzureTenant>() { CreateTenant(tenant) };
             }
 
-            List<AzureTenant> tenants = ListAccountTenants(_profile.DefaultContext.Account, _profile.DefaultContext.Environment, null, ShowDialog.Never, null);
+            List<AzureTenant> tenants = ListAccountTenants(DefaultContext.Account, DefaultContext.Environment, null, ShowDialog.Never, null);
             return tenants.Where(t => string.IsNullOrEmpty(tenant) ||
                                          tenant.Equals(t.Id.ToString(), StringComparison.OrdinalIgnoreCase) ||
                                          tenant.Equals(t.Directory, StringComparison.OrdinalIgnoreCase))