Merge pull request #109 from diydrones/Manually-Do-Pull-Request--(

Manually Re-Code Pull Request

Author: bionicbone

AMP Log Analiser x1.v12.suo

@@ -35,14 +35,6 @@ Module modFile_Handling
         FileDataSuitable = False
         ' Function returns True if we need to exit the file processing.
 
-        ' v3.2 Issue - Display warning if Params have been found at the end
-        If WarnAboutExtraParams = True Then
-            WriteTextLog("WARNING: Curruption Of Parameter Lines Detected!")
-            WriteTextLog("WARNING: the Analyzer tried to handle them.")
-            WriteTextLog("WARNING: This is a v3.2 firmware issue that has been reported!")
-            WriteTextLog("")
-        End If
-
         ' v3.2 Issue - Display warning if FMTs have been found at the end
         If WarnAboutExtraFMT = True Then
             WriteTextLog("WARNING: Curruption Of FMT Lines Detected!")
@@ -257,11 +249,6 @@ Module modFile_Handling
             ' Parameter Support for all Firmwares
             'A Parameter value should have only 3 pieces of data!
             If DataArray(0) = "PARM" Then
-                If EndOfPARAM = True And IgnoreMoreParam = False Then
-                    WarnAboutExtraParams = True
-                    'MsgBox("Curruption Of Parameters Detected, the Analyzer is trying to handle them (V3.2 issue)!", vbOKOnly & vbExclamation, "Warning!")
-                    IgnoreMoreParam = True
-                End If
                 EndOfFMT = True
                 If IsNumeric(DataArray(2)) = False Or IsNothing(DataArray(3)) = False Then
                     Debug.Print("================================================================")

AMP Log Analiser x1/Classes/modFile_Handling.vb

@@ -14,32 +14,12 @@
         'and advise that if the Motors do not spin on Arming then increase the
         'Motor Spin Arm upto a Max of Throttle Min.
         If PARM_THR_MIN <> 99 Or PARM_MOT_SPIN_ARMED <> 99 Then
-            If PARM_MOT_SPIN_ARMED = 70 Then
-                Call WriteParamHeader()
-                WriteTextLog("MOT_SPIN_ARMED = " & PARM_MOT_SPIN_ARMED)
-                WriteTextLog("Advice: If motors do not spin when armed calibrate ESC and then try increasing")
-                WriteTextLog("the parameter MOT_SPIN_ARMED up from 70 in small increments.")
-                WriteTextLog("http://ardupilot.com/forum/viewtopic.php?f=25&t=5345&sid=3171087bcf7d84e03491e1845eaa9393")
-                WriteTextLog(vbNewLine)
-            End If
-            If PARM_THR_MIN <> 0 And PARM_MOT_SPIN_ARMED <> 0 Then
-                If PARM_THR_MIN <> 130 Or PARM_MOT_SPIN_ARMED <> 70 Then
-                    Call WriteParamHeader()
-                    WriteTextLog("THR_MIN = " & PARM_THR_MIN)
-                    WriteTextLog("MOT_SPIN_ARMED = " & PARM_MOT_SPIN_ARMED)
-                    WriteTextLog("Warning: MOT_SPIN_ARMED & THR_MIN parameters have been altered from their defaults.")
-                    WriteTextLog("They should be 70 & 130 respectively unless the motors do not spin when armed.")
-                    WriteTextLog("http://ardupilot.com/forum/viewtopic.php?f=25&t=5345&sid=3171087bcf7d84e03491e1845eaa9393")
-                    WriteTextLog(vbNewLine)
-                End If
-            End If
             If PARM_THR_MIN <> 0 And PARM_MOT_SPIN_ARMED <> 0 Then
                 If PARM_MOT_SPIN_ARMED > PARM_THR_MIN Then
                     Call WriteParamHeader()
                     WriteTextLog("THR_MIN = " & PARM_THR_MIN)
                     WriteTextLog("MOT_SPIN_ARMED = " & PARM_MOT_SPIN_ARMED)
                     WriteTextLog("Warning: MOT_SPIN_ARMED is greater then THR_MIN parameter, this is dangerous!")
-                    WriteTextLog("These parameter should be 70 & 130 respectively unless the motors do not spin when armed.")
                     WriteTextLog("http://ardupilot.com/forum/viewtopic.php?f=25&t=5345&sid=3171087bcf7d84e03491e1845eaa9393")
                     WriteTextLog(vbNewLine)
                 End If

AMP Log Analiser x1/Classes/modPARAM_Checks.vb

@@ -84,8 +84,6 @@ Module modVariable_Declarations
     Public EndOfFMT As Boolean = False                             'True when we find the first parameter of data.
     Public FoundPARAM As Boolean = False                           'True when the first PARAM line is found.
     Public EndOfPARAM As Boolean = False                           'True when we find the first Data
-    Public IgnoreMoreParam As Boolean = False                      ' True when the user has already been warned about the extra Parameters found.
-    Public WarnAboutExtraParams As Boolean = False                  ' True if the log should report that parameters were found at the end (v3.2 issue)
     Public WarnAboutExtraFMT As Boolean = False                  ' True if the log should report that FMTs were found at the end (v3.2 issue)
     Public TruncationIssue As Boolean = False                   'Used during DataLog file reading to detect truncation issues.
 

AMP Log Analiser x1/Classes/modVariable_Declarations.vb

@@ -10,8 +10,6 @@
         EndOfFMT = False                             'True when we find the first parameter of data.
         FoundPARAM = False                           'True when the first PARAM line is found.
         EndOfPARAM = False                           'True when we find the first Data
-        IgnoreMoreParam = False                      ' True when the user has already been warned about the extra Parameters found.
-        WarnAboutExtraParams = False                  ' True if the log should report that parameters were found at the end (v3.2 issue)
         WarnAboutExtraFMT = False                  ' True if the log should report that FMTs were found at the end (v3.2 issue)
         TruncationIssue = False                         'Used during DataLog file reading to detect truncation issues.