fix: Simplify Module::get_global_metadata and Values::get_node_values.

The previous fixes were OK-ish. This patch is better since it doesn't
forget the `raw_vec` but forces the length of the `Vec` to `count`.

Author: Hywan

src/module.rs

@@ -932,15 +932,13 @@ impl<'ctx> Module<'ctx> {
         let c_string = to_c_str(key);
         let count = self.get_global_metadata_size(key) as usize;
 
-        let mut raw_vec: Vec<LLVMValueRef> = Vec::with_capacity(count);
-        let ptr = raw_vec.as_mut_ptr();
+        let mut vec: Vec<LLVMValueRef> = Vec::with_capacity(count);
+        let ptr = vec.as_mut_ptr();
 
-        forget(raw_vec);
-
-        let vec = unsafe {
+        unsafe {
             LLVMGetNamedMetadataOperands(self.module.get(), c_string.as_ptr(), ptr);
 
-            Vec::from_raw_parts(ptr, count, count)
+            vec.set_len(count);
         };
 
         vec.iter().map(|val| MetadataValue::new(*val)).collect()

src/values/metadata_value.rs

@@ -110,15 +110,13 @@ impl<'ctx> MetadataValue<'ctx> {
         }
 
         let count = self.get_node_size() as usize;
-        let mut raw_vec: Vec<LLVMValueRef> = Vec::with_capacity(count);
-        let ptr = raw_vec.as_mut_ptr();
+        let mut vec: Vec<LLVMValueRef> = Vec::with_capacity(count);
+        let ptr = vec.as_mut_ptr();
 
-        forget(raw_vec);
-
-        let vec = unsafe {
+        unsafe {
             LLVMGetMDNodeOperands(self.as_value_ref(), ptr);
 
-            Vec::from_raw_parts(ptr, count, count)
+            vec.set_len(count)
         };
 
         vec.iter()