Skip to content

add eclipse-temurin logo #2014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 18, 2021
Merged

add eclipse-temurin logo #2014

merged 1 commit into from
Aug 18, 2021

Conversation

gdams
Copy link
Contributor

@gdams gdams commented Aug 18, 2021

Please can somebody also set the actual image logo as this one below: CC @tianon

Logo_Temurin_2021_08_17_JRR_RGB-V1B

@tianon
Copy link
Member

tianon commented Aug 18, 2021

I'm a little confused here -- your PR description includes a vertical/square image, but the PR itself includes a wide image. 😕

I think there's a delay on Docker's backend (I'm honestly not sure why it's not updated yet -- it really should be), but this same logo is also used in the following place:

image

@gdams
Copy link
Contributor Author

gdams commented Aug 18, 2021

@tianon I didn't realise that they used the same logo. If that's the case then let's stick with the wide image

@tianon
Copy link
Member

tianon commented Aug 18, 2021

Alright, will do 😄

You can see where it's supposed to be working from https://d1q6f0aelx0por.cloudfront.net/product-logos/library-eclipse-temurin-logo.png (which is the URL it's supposed to pull that from, as I understand it, and you can see that our script did successfully update that file). 😕 😅

@tianon tianon merged commit f061388 into docker-library:master Aug 18, 2021
@gdams gdams deleted the temurin branch August 18, 2021 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants