-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Add deprecation notice for CentOS #2205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
centos/deprecated.md
Outdated
@@ -0,0 +1 @@ | |||
This image is no longer supported/maintained (last updated September 15, 2021, [docker-library/official-images#10304](https://github.com/docker-library/official-images/pull/10304); see also https://www.centos.org/centos-linux-eol/). Please adjust your usage accordingly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this point to the earlier PRs that actually changed 7.x
(docker-library/official-images#9082 and docker-library/official-images#9102 for ppc64le
and docker-library/official-images#5146 for arm32v7
🙈)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, it's a bit complicated! This PR is the last time the image maintainer updated any tag of the image, but there's one slightly newer where you removed the EOL versions (which is what the PR I linked to was updating) where these are the most recent PRs to update an ostensibly "supported" version. 😩
Maybe we should change the wording to make it clear this is the last time the maintainer updated any part of the image, not necessarily the supported tags? Maybe we should instead drop this bit of the message entirely? Not sure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, updated with some alternative wording for your consideration. 🙇
6ad9bd5
to
1e2840b
Compare
1e2840b
to
340821e
Compare
For future readers of this PR, I'd like to be absolutely clear that I'd love to revert this! ❤️ What's necessary for that to happen is a proper update to the supported versions of CentOS, and a commitment to keep them appropriately updated in the future (on a timely schedule -- we recommend once a month at the very most). 🙇 |
Closes docker-library/official-images#11679