Add alpine fpm variant #72
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Hey @sylus, thanks for the contribution and your patience ❤️ I was reviewing this and noticed a bunch of consistency changes I wanted to make around this, so I took the liberty of just doing those on top of your additions (so that your additions could be included too). 👍 ❤️ Hopefully we can get this in shortly! (I've asked @yosifkit to take a look now) |
yosifkit
approved these changes
Mar 1, 2017
tianon
added a commit
to infosiftr/stackbrew
that referenced
this pull request
Mar 1, 2017
- `drupal`: 8.3.0-rc1, add `fpm-alpine` variants (docker-library/drupal#72) - `elasticsearch`: 5.2.2 - `ghost`: 0.11.7 - `golang`: remove 1.6 - `haproxy`: 1.7.3 - `kibana`: 5.2.2 - `logstash`: 5.2.2 - `piwik`: 3.0.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just adding some awesome alpine support. ^_^
I didn't touch the apache conf given:
docker-library/php#259
I also updated the
update.shscript but wasn't sure if any changes needed to thegenerate-stackbrew-library.shfile.Closes #73