Use PHP 7.1 on Alpine and be consistent #80
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hah, whoops! 👍 🤘 |
tianon
added a commit
to infosiftr/stackbrew
that referenced
this pull request
Apr 7, 2017
- `drupal`: 8.3.0 (docker-library/drupal#78), remove 8.2 (docker-library/drupal#80) - `ghost`: add `alpine` variant (docker-library/ghost#55) - `mongo`: more edge cases (docker-library/mongo#167, docker-library/mongo#169) - `postgres`: adjust append (docker-library/postgres#270) - `rabbitmq`: add `vm_memory_high_watermark` support based on cgroup limits (docker-library/rabbitmq#105) - `rocket.chat`: 0.55.0-rc.1 - `wordpress`: add `wp-cli` variant (docker-library/wordpress#198)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just realized that Alpine was still using PHP7.0 on Drupal 8.3.x while other flavors already using PHP7.1. So, update this image to use PHP7.1. The official Drupal document suggests no problem with 7.1. https://www.drupal.org/docs/7/system-requirements/php and on the other hand, known and future PHP7.1 compatibility issues with Core or with 3-rd parties will be worked on https://www.drupal.org/project/issues/search?text=&projects=&assigned=&submitted=&project_issue_followers=&status%5B%5D=Open&issue_tags_op=%3D&issue_tags=PHP+7.1