Add libc-dev as an explicit phpize dependency #73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 LGTM! ❤️ |
|
LGTM |
yosifkit
added a commit
that referenced
this pull request
Mar 6, 2015
Add libc-dev as an explicit phpize dependency
This was referenced Mar 6, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like the changes related to
--auto-removein #71 had the inadvertent side effect of breakingdocker-php-ext-install. This patch explicitly adds backlibc-devas a dependency, but another option in this case might be to simply revert #71.The reason I did the former instead of the latter is that I still think that the
APT::AutoRemove::RecommendsImportant=falsepattern is a good one in general since it can prevent packages from getting left in an image inadvertently. That being said, in the case of thephp:*images, the end result would be the same.