Add a warning for cases where WORDPRESS_CONFIG_EXTRA will not take effect #342
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yosifkit
approved these changes
Oct 10, 2018
tianon
added a commit
to infosiftr/stackbrew
that referenced
this pull request
Oct 11, 2018
- `ghost`: 2.2.2 - `joomla`: 3.8.13 - `memcached`: 1.5.11 - `openjdk`: 12-ea+15 - `php`: 7.3.0RC3 - `postgres`: 11rc1 - `redis`: 5.0-rc6 - `rocket.chat`: 0.70.4 - `wordpress`: `WORDPRESS_CONFIG_EXTRA` warning (docker-library/wordpress#342)
|
Sorry but that's a terrible solution and the discussion linked doesn't provide a solution... so the official WordPress images aren't working for WordPress. Adding multisite env vars isn't possible! that's a shame! Could do we find a better solution? It was working before, why has it been changed? |
|
Ignoring the poor tone of your message (which I'll ask you to keep more respectful in the future), you'll likely be interested in #557, which implements this differently such that updates to the value will apply retroactively. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #333
If
WORDPRESS_CONFIG_EXTRAis set,wp-config.phpalready exists, and the contents ofWORDPRESS_CONFIG_EXTRAdo not already exist in the existingwp-config.php, this will print a warning (which then points to #333, which includes discussion of workarounds for folks who need this value to be updated more dynamically).