Skip to content

Commit 98aa0e9

Browse files
authored
Merge pull request #195 from greg0ire/makefile-improvements
Makefile improvements
2 parents d2cd712 + f66a686 commit 98aa0e9

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

Makefile

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
.PHONY: test test-report test-fix update-compatibility-patch
22

3-
PHP_74_OR_NEWER=`php -r "echo (int) version_compare(PHP_VERSION, '7.4', '>=');"`
3+
PHP_74_OR_NEWER:=$(shell php -r "echo (int) version_compare(PHP_VERSION, '7.4', '>=');")
44

55
test: test-report test-fix
66

@@ -17,10 +17,11 @@ test-fix: vendor
1717

1818
update-compatibility-patch:
1919
@git apply tests/php-compatibility.patch
20-
@echo -e "Please open your editor and apply your changes\n"
20+
@printf "Please open your editor and apply your changes\n"
2121
@until [ "$${compatibility_resolved}" == "y" ]; do read -p "Have finished your changes (y|n)? " compatibility_resolved; done && compatibility_resolved=
2222
@git diff -- tests/expected_report.txt tests/fixed > .tmp-patch && mv .tmp-patch tests/php-compatibility.patch && git apply -R tests/php-compatibility.patch
2323
@git commit -m 'Update compatibility patch' tests/php-compatibility.patch
2424

2525
vendor: composer.json
2626
composer update
27+
touch -c vendor

0 commit comments

Comments
 (0)