Skip to content

Move website config to default branch #221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 15, 2020
Merged

Conversation

SenseException
Copy link
Member

Adapts the website config to be compatible with the doctrine/doctrine-website#356 changes

Do we need to have 8.0 in the docs?

@SenseException
Copy link
Member Author

SenseException commented Oct 7, 2020

This is the last PR that involves moving .doctrine-project.json to the default branch. After this doctrine/doctrine-website#356 is ready for review

@greg0ire
Copy link
Member

Do we need to have 8.0 in the docs?

Based on semver I'd say yes, otherwise people might wrongly think some feature that is available exclusively in 8.1 is available in 8.0 too. Also, do we usually skip some minor branches in the docs, in other repositories?

Adapts the website config to be compatible with the doctrine/doctrine-website#356 changes
@SenseException SenseException force-pushed the default-branch-website-config branch from 8e3612e to 30863ee Compare October 14, 2020 21:43
@SenseException
Copy link
Member Author

I wasn't sure because there are usually only one entry per major version in the coding-standard. I've added 8.0 now.

@greg0ire greg0ire requested a review from a team October 15, 2020 16:58
@greg0ire greg0ire requested a review from a team October 15, 2020 17:35
@greg0ire greg0ire merged commit b27f98f into 8.1.x Oct 15, 2020
@greg0ire greg0ire deleted the default-branch-website-config branch October 15, 2020 17:50
@greg0ire
Copy link
Member

Thanks @SenseException !

@greg0ire greg0ire added this to the 8.2.0 milestone Oct 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants