Fixed assert_eq!() testcase #2

Kimundi · 2013-05-09T16:47:06Z

No description provided.

… -> fail!("...") cleanup

dotdash · 2013-05-09T16:53:15Z

Integrated.

…inger Attempt #2 of [this pull request](rust-lang#8597) since my tired mind decided messing up my repo, then deleting and re-forking was a good idea. This is identical to the second last commit in that PR. (The one before I ruined everything.) This is an improvement to use_decl docs, which will hopefully improve understanding of how resolution works and where `extern mod` and module declarations should go to make them visible to use declarations.

Tiny typo of "positive"

When given the following code: ```rust fn give_any<F: for<'r> FnOnce(&'r ())>(f: F) { f(&()); } fn main() { let mut x = None; give_any(|y| x = Some(y)); } ``` provide a custom error: ``` error: borrowed data cannot be moved outside of its closure --> file.rs:7:27 | 6 | let mut x = None; | ----- binding declared outside of closure 7 | give_any(|y| x = Some(y)); | --- ^ cannot be assigned to binding outside of its closure | | | closure you can't escape ``` instead of the generic lifetime error: ``` error[E0495]: cannot infer an appropriate lifetime due to conflicting requirements --> file.rs:7:27 | 7 | give_any(|y| x = Some(y)); | ^ | note: first, the lifetime cannot outlive the anonymous lifetime #2 defined on the body at 7:14... --> file.rs:7:14 | 7 | give_any(|y| x = Some(y)); | ^^^^^^^^^^^^^^^ note: ...so that expression is assignable (expected &(), found &()) --> file.rs:7:27 | 7 | give_any(|y| x = Some(y)); | ^ note: but, the lifetime must be valid for the block suffix following statement 0 at 6:5... --> file.rs:6:5 | 6 | / let mut x = None; 7 | | give_any(|y| x = Some(y)); 8 | | } | |_^ note: ...so that variable is valid at time of its declaration --> file.rs:6:9 | 6 | let mut x = None; | ^^^^^ ```

…sakis Custom error when moving arg outside of its closure When given the following code: ```rust fn give_any<F: for<'r> FnOnce(&'r ())>(f: F) { f(&()); } fn main() { let mut x = None; give_any(|y| x = Some(y)); } ``` provide a custom error: ``` error: borrowed data cannot be moved outside of its closure --> file.rs:7:27 | 6 | let mut x = None; | ----- borrowed data cannot be moved into here... 7 | give_any(|y| x = Some(y)); | --- ^ cannot be moved outside of its closure | | | ...because it cannot outlive this closure ``` instead of the generic lifetime error: ``` error[E0495]: cannot infer an appropriate lifetime due to conflicting requirements --> file.rs:7:27 | 7 | give_any(|y| x = Some(y)); | ^ | note: first, the lifetime cannot outlive the anonymous lifetime #2 defined on the body at 7:14... --> file.rs:7:14 | 7 | give_any(|y| x = Some(y)); | ^^^^^^^^^^^^^^^ note: ...so that expression is assignable (expected &(), found &()) --> file.rs:7:27 | 7 | give_any(|y| x = Some(y)); | ^ note: but, the lifetime must be valid for the block suffix following statement 0 at 6:5... --> file.rs:6:5 | 6 | / let mut x = None; 7 | | give_any(|y| x = Some(y)); 8 | | } | |_^ note: ...so that variable is valid at time of its declaration --> file.rs:6:9 | 6 | let mut x = None; | ^^^^^ ``` Fix rust-lang#45983.

Some review feedback and other misc tweaks

…erister Use arenas to avoid Lrc in queries #2 The `Remove subtle Default impl for Value` makes the compilation stop due earlier due to cycle errors, since there's no longer a default value to continue the compilation with. Based on rust-lang#59540.

@ghost

Rollup of 6 pull requests Successful merges: - rust-lang#59545 (Use arenas to avoid Lrc in queries #2) - rust-lang#61054 (Suggest dereferencing on assignment to mutable borrow) - rust-lang#61056 (tweak discriminant on non-nullary enum diagnostic) - rust-lang#61082 (fix dangling reference in Vec::append) - rust-lang#61086 (Box::into_unique: do the reborrow-to-raw *after* destroying the Box) - rust-lang#61098 (Fix overflowing literal lint in loops) Failed merges: r? @ghost

Kimundi added 2 commits May 9, 2013 16:09

Diff of own seperate fail!(fmt!(...)) -> fail!(...) and fail!(~"...")…

2e8e10f

… -> fail!("...") cleanup

fixup

98ca5d5

dotdash closed this May 9, 2013

dotdash pushed a commit that referenced this pull request Aug 5, 2015

Merge pull request #2 from ben0x539/patch-1

2d5c1bb

Tiny typo of "positive"

dotdash pushed a commit that referenced this pull request Jun 18, 2019

Merge pull request #2 from alexcrichton/azure-pipelines

e6830c1

Some review feedback and other misc tweaks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fixed assert_eq!() testcase #2

Fixed assert_eq!() testcase #2

Uh oh!

Kimundi commented May 9, 2013

Uh oh!

dotdash commented May 9, 2013

Uh oh!

Uh oh!

Fixed assert_eq!() testcase #2

Fixed assert_eq!() testcase #2

Uh oh!

Conversation

Kimundi commented May 9, 2013

Uh oh!

dotdash commented May 9, 2013

Uh oh!

Uh oh!