Respond to new code analysis warnings.

Author: eerhardt

src/Caching/StackExchangeRedis/src/RedisCache.cs

@@ -573,10 +573,12 @@ private async Task RefreshAsync(IDatabase cache, string key, DateTimeOffset? abs
     {
         if (options.AbsoluteExpiration.HasValue && options.AbsoluteExpiration <= creationTime)
         {
+#pragma warning disable CA2208 // Instantiate argument exceptions correctly
             throw new ArgumentOutOfRangeException(
                 nameof(DistributedCacheEntryOptions.AbsoluteExpiration),
                 options.AbsoluteExpiration.Value,
                 "The absolute expiration value must be in the future.");
+#pragma warning restore CA2208 // Instantiate argument exceptions correctly
         }
 
         if (options.AbsoluteExpirationRelativeToNow.HasValue)

src/Components/Components/src/Routing/TemplateSegment.cs

@@ -23,8 +23,7 @@ public TemplateSegment(string template, string segment, bool isParameter)
                 Value = segment[1..];
             }
 
-            var invalidCharacterIndex = Value.IndexOf('*');
-            if (invalidCharacterIndex != -1)
+            if (Value.Contains('*'))
             {
                 throw new InvalidOperationException($"Invalid template '{template}'. A catch-all parameter may only have '*' or '**' at the beginning of the segment.");
             }
@@ -93,7 +92,7 @@ public TemplateSegment(string template, string segment, bool isParameter)
 
             // Moving the check for this here instead of TemplateParser so we can allow catch-all.
             // We checked for '*' up above specifically for catch-all segments, this one checks for all others
-            if (Value.IndexOf('*') != -1)
+            if (Value.Contains('*'))
             {
                 throw new InvalidOperationException($"Invalid template '{template}'. The character '*' in parameter segment '{{{segment}}}' is not allowed.");
             }

src/Http/Http/src/Internal/ResponseCookies.cs

@@ -122,20 +122,20 @@ public void Delete(string key, CookieOptions options)
         {
             rejectPredicate = (value, encKeyPlusEquals, opts) =>
                 value.StartsWith(encKeyPlusEquals, StringComparison.OrdinalIgnoreCase) &&
-                    value.IndexOf($"domain={opts.Domain}", StringComparison.OrdinalIgnoreCase) != -1 &&
-                    value.IndexOf($"path={opts.Path}", StringComparison.OrdinalIgnoreCase) != -1;
+                    value.Contains($"domain={opts.Domain}", StringComparison.OrdinalIgnoreCase) &&
+                    value.Contains($"path={opts.Path}", StringComparison.OrdinalIgnoreCase);
         }
         else if (domainHasValue)
         {
             rejectPredicate = (value, encKeyPlusEquals, opts) =>
                 value.StartsWith(encKeyPlusEquals, StringComparison.OrdinalIgnoreCase) &&
-                    value.IndexOf($"domain={opts.Domain}", StringComparison.OrdinalIgnoreCase) != -1;
+                    value.Contains($"domain={opts.Domain}", StringComparison.OrdinalIgnoreCase);
         }
         else if (pathHasValue)
         {
             rejectPredicate = (value, encKeyPlusEquals, opts) =>
                 value.StartsWith(encKeyPlusEquals, StringComparison.OrdinalIgnoreCase) &&
-                    value.IndexOf($"path={opts.Path}", StringComparison.OrdinalIgnoreCase) != -1;
+                    value.Contains($"path={opts.Path}", StringComparison.OrdinalIgnoreCase);
         }
         else
         {

src/Http/Routing/src/Patterns/RoutePatternParser.cs

@@ -441,7 +441,7 @@ private static bool IsValidLiteral(Context context, string literal)
         Debug.Assert(context != null);
         Debug.Assert(literal != null);
 
-        if (literal.IndexOf(QuestionMark) != -1)
+        if (literal.Contains(QuestionMark))
         {
             context.Error = Resources.FormatTemplateRoute_InvalidLiteral(literal);
             return false;

src/Logging.AzureAppServices/src/BatchingLoggerProvider.cs

@@ -39,11 +39,15 @@ internal BatchingLoggerProvider(IOptionsMonitor<BatchingLoggerOptions> options)
         var loggerOptions = options.CurrentValue;
         if (loggerOptions.BatchSize <= 0)
         {
+#pragma warning disable CA2208 // Instantiate argument exceptions correctly
             throw new ArgumentOutOfRangeException(nameof(loggerOptions.BatchSize), $"{nameof(loggerOptions.BatchSize)} must be a positive number.");
+#pragma warning restore CA2208 // Instantiate argument exceptions correctly
         }
         if (loggerOptions.FlushPeriod <= TimeSpan.Zero)
         {
+#pragma warning disable CA2208 // Instantiate argument exceptions correctly
             throw new ArgumentOutOfRangeException(nameof(loggerOptions.FlushPeriod), $"{nameof(loggerOptions.FlushPeriod)} must be longer than zero.");
+#pragma warning restore CA2208 // Instantiate argument exceptions correctly
         }
 
         _interval = loggerOptions.FlushPeriod;

src/Tools/Shared/CommandLine/CommandLineApplicationExtensions.cs

@@ -26,7 +26,7 @@ public static CommandOption Option(this CommandLineApplication command, string t
         => command.Option(
             template,
             description,
-            template.IndexOf("<", StringComparison.Ordinal) != -1
+            template.Contains('<')
                 ? template.EndsWith(">...", StringComparison.Ordinal) ? CommandOptionType.MultipleValue : CommandOptionType.SingleValue
                 : CommandOptionType.NoValue);