Improve detection of Record types (#24409)

pranavkm · web-flow · commit 17687f538c85 · 2020-07-29T13:27:27.000-07:00
diff --git a/src/Mvc/Mvc.Core/src/ModelBinding/Metadata/DefaultBindingMetadataProvider.cs b/src/Mvc/Mvc.Core/src/ModelBinding/Metadata/DefaultBindingMetadataProvider.cs
@@ -143,7 +143,8 @@ private static ConstructorInfo GetRecordTypeConstructor(Type type, ConstructorIn
             static bool IsRecordType(Type type)
             {
                 // Based on the state of the art as described in https://github.com/dotnet/roslyn/issues/45777
-                var cloneMethod = type.GetMethod("<>Clone", BindingFlags.Public | BindingFlags.Instance);
+                var cloneMethod = type.GetMethod("<Clone>$", BindingFlags.Public | BindingFlags.Instance) ??
+                    type.GetMethod("<>Clone", BindingFlags.Public | BindingFlags.Instance);
                 return cloneMethod != null && cloneMethod.ReturnType == type;
             }
         }

Original file line number	Diff line number	Diff line change
`@@ -143,7 +143,8 @@ private static ConstructorInfo GetRecordTypeConstructor(Type type, ConstructorIn`
`143`	`143`	`static bool IsRecordType(Type type)`
`144`	`144`	`{`
`145`	`145`	`// Based on the state of the art as described in https://github.com/dotnet/roslyn/issues/45777`
`146`		`- var cloneMethod = type.GetMethod("<>Clone", BindingFlags.Public \| BindingFlags.Instance);`
	`146`	`+ var cloneMethod = type.GetMethod("<Clone>$", BindingFlags.Public \| BindingFlags.Instance) ??`
	`147`	`+ type.GetMethod("<>Clone", BindingFlags.Public \| BindingFlags.Instance);`
`147`	`148`	`return cloneMethod != null && cloneMethod.ReturnType == type;`
`148`	`149`	`}`
`149`	`150`	`}`