Revert "Clear route values after middleware invocation."

This reverts commit c54a720.

Author: N. Taylor Mullen

src/Http/Routing/src/EndpointRoutingMiddleware.cs

@@ -3,10 +3,10 @@
 
 using System;
 using System.Diagnostics;
+using System.Runtime.CompilerServices;
 using System.Threading;
 using System.Threading.Tasks;
 using Microsoft.AspNetCore.Http;
-using Microsoft.AspNetCore.Http.Features;
 using Microsoft.AspNetCore.Routing.Matching;
 using Microsoft.Extensions.Logging;
 
@@ -116,9 +116,6 @@ private async Task SetRoutingAndContinue(HttpContext httpContext)
             {
                 // This allows a second call in a single request (such as from the ErrorHandlerMiddleware) to perform routing again.
                 httpContext.SetEndpoint(endpoint: null);
-
-                var routeValuesFeature = httpContext.Features.Get<IRouteValuesFeature>();
-                routeValuesFeature?.RouteValues?.Clear();
             }
         }
 

src/Http/Routing/test/UnitTests/Builder/EndpointRoutingApplicationBuilderExtensionsTest.cs

@@ -74,7 +74,7 @@ public async Task UseRouting_ServicesRegistered_NoMatch_DoesNotSetFeature()
         }
 
         [Fact]
-        public async Task UseRouting_ServicesRegistered_Match_DoesNotSetFeature()
+        public async Task UseRouting_ServicesRegistered_Match_DoesNotSetsFeature()
         {
             // Arrange
             var endpoint = new RouteEndpoint(
@@ -104,6 +104,7 @@ public async Task UseRouting_ServicesRegistered_Match_DoesNotSetFeature()
             // Assert
             var feature = httpContext.Features.Get<IEndpointFeature>();
             Assert.NotNull(feature);
+            Assert.Same(endpoint, httpContext.GetEndpoint());
         }
 
         [Fact]

src/Http/Routing/test/UnitTests/EndpointRoutingMiddlewareTest.cs

@@ -102,26 +102,6 @@ public async Task Invoke_OnCall_SetsEndpointFeatureAndResetsEndpoint()
             Assert.Null(endpointFeature.Endpoint);
         }
 
-        [Fact]
-        public async Task Invoke_OnCall_SetsEndpointFeatureAndResetsRouteValues()
-        {
-            // Arrange
-            var httpContext = CreateHttpContext();
-            var initialRouteData = new RouteData();
-            initialRouteData.Values["test"] = true;
-            httpContext.Features.Set<IRoutingFeature>(new RoutingFeature()
-            {
-                RouteData = initialRouteData,
-            });
-            var middleware = CreateMiddleware();
-
-            // Act
-            await middleware.Invoke(httpContext);
-
-            // Assert
-            Assert.Null(httpContext.GetRouteValue("test"));
-        }
-
         [Fact]
         public async Task Invoke_SkipsRoutingAndMaintainsEndpoint_IfEndpointSet()
         {
@@ -182,59 +162,45 @@ public async Task Invoke_BackCompatGetRouteValue_ValueUsedFromEndpointFeature()
         {
             // Arrange
             var httpContext = CreateHttpContext();
-            var nextCalled = false;
 
-            var middleware = CreateMiddleware(next: context =>
-            {
-                var routeData = httpContext.GetRouteData();
-                var routeValue = httpContext.GetRouteValue("controller");
-                var routeValuesFeature = httpContext.Features.Get<IRouteValuesFeature>();
-                nextCalled = true;
-
-                // Assert
-                Assert.NotNull(routeData);
-                Assert.Equal("Home", (string)routeValue);
+            var middleware = CreateMiddleware();
 
-                // changing route data value is reflected in endpoint feature values
-                routeData.Values["testKey"] = "testValue";
-                Assert.Equal("testValue", routeValuesFeature.RouteValues["testKey"]);
+            // Act
+            await middleware.Invoke(httpContext);
+            var routeData = httpContext.GetRouteData();
+            var routeValue = httpContext.GetRouteValue("controller");
+            var routeValuesFeature = httpContext.Features.Get<IRouteValuesFeature>();
 
-                return Task.CompletedTask;
-            });
+            // Assert
+            Assert.NotNull(routeData);
+            Assert.Equal("Home", (string)routeValue);
 
-            // Act & Assert
-            await middleware.Invoke(httpContext);
-            Assert.True(nextCalled);
+            // changing route data value is reflected in endpoint feature values
+            routeData.Values["testKey"] = "testValue";
+            Assert.Equal("testValue", routeValuesFeature.RouteValues["testKey"]);
         }
 
         [Fact]
         public async Task Invoke_BackCompatGetDataTokens_ValueUsedFromEndpointMetadata()
         {
             // Arrange
             var httpContext = CreateHttpContext();
-            var called = false;
 
-            var middleware = CreateMiddleware(next: context =>
-            {
-                var routeData = httpContext.GetRouteData();
-                var routeValue = httpContext.GetRouteValue("controller");
-                var routeValuesFeature = httpContext.Features.Get<IRouteValuesFeature>();
-                called = true;
-
-                // Assert
-                Assert.NotNull(routeData);
-                Assert.Equal("Home", (string)routeValue);
+            var middleware = CreateMiddleware();
 
-                // changing route data value is reflected in endpoint feature values
-                routeData.Values["testKey"] = "testValue";
-                Assert.Equal("testValue", routeValuesFeature.RouteValues["testKey"]);
+            // Act
+            await middleware.Invoke(httpContext);
+            var routeData = httpContext.GetRouteData();
+            var routeValue = httpContext.GetRouteValue("controller");
+            var routeValuesFeature = httpContext.Features.Get<IRouteValuesFeature>();
 
-                return Task.CompletedTask;
-            });
+            // Assert
+            Assert.NotNull(routeData);
+            Assert.Equal("Home", (string)routeValue);
 
-            // Act & Assert
-            await middleware.Invoke(httpContext);
-            Assert.True(called);
+            // changing route data value is reflected in endpoint feature values
+            routeData.Values["testKey"] = "testValue";
+            Assert.Equal("testValue", routeValuesFeature.RouteValues["testKey"]);
         }
 
         [Fact]