Skip to content

Commit 1e281bf

Browse files
TratcherTratcher
committed
Rename compat flag
1 parent 6c92d4f commit 1e281bf

File tree

2 files changed

+21
-21
lines changed

2 files changed

+21
-21
lines changed

‎src/Http/Headers/src/SetCookieHeaderValue.cs

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ public class SetCookieHeaderValue
2626

2727
// True (old): https://tools.ietf.org/html/draft-west-first-party-cookies-07#section-3.1
2828
// False (new): https://tools.ietf.org/html/draft-ietf-httpbis-rfc6265bis-03#section-4.1.1
29-
internal static bool UseSameSite2016Compat;
29+
internal static bool SuppressSameSiteNone;
3030

3131
private const string HttpOnlyToken = "httponly";
3232
private const string SeparatorToken = "; ";
@@ -44,9 +44,9 @@ private static readonly HttpHeaderParser<SetCookieHeaderValue> MultipleValuePars
4444

4545
static SetCookieHeaderValue()
4646
{
47-
if (AppContext.TryGetSwitch("Microsoft.Net.Http.Headers.SetCookieHeaderValue.UseSameSite2016Compat", out var enabled))
47+
if (AppContext.TryGetSwitch("Microsoft.Net.Http.Headers.SetCookieHeaderValue.SuppressSameSiteNone", out var enabled))
4848
{
49-
UseSameSite2016Compat = enabled;
49+
SuppressSameSiteNone = enabled;
5050
}
5151
}
5252

@@ -106,7 +106,7 @@ public StringSegment Value
106106

107107
public bool Secure { get; set; }
108108

109-
public SameSiteMode SameSite { get; set; } = UseSameSite2016Compat ? SameSiteMode.None : (SameSiteMode)(-1); // Unspecified
109+
public SameSiteMode SameSite { get; set; } = SuppressSameSiteNone ? SameSiteMode.None : (SameSiteMode)(-1); // Unspecified
110110

111111
public bool HttpOnly { get; set; }
112112

@@ -145,7 +145,7 @@ public override string ToString()
145145
}
146146

147147
// Allow for Unspecified (-1) to skip SameSite
148-
if (SameSite == SameSiteMode.None && !UseSameSite2016Compat)
148+
if (SameSite == SameSiteMode.None && !SuppressSameSiteNone)
149149
{
150150
sameSite = SameSiteNoneToken;
151151
length += SeparatorToken.Length + SameSiteToken.Length + EqualsToken.Length + sameSite.Length;
@@ -275,7 +275,7 @@ public void AppendToStringBuilder(StringBuilder builder)
275275
}
276276

277277
// Allow for Unspecified (-1) to skip SameSite
278-
if (SameSite == SameSiteMode.None && !UseSameSite2016Compat)
278+
if (SameSite == SameSiteMode.None && !SuppressSameSiteNone)
279279
{
280280
AppendSegment(builder, SameSiteToken, SameSiteNoneToken);
281281
}
@@ -478,7 +478,7 @@ private static int GetSetCookieLength(StringSegment input, int startIndex, out S
478478
{
479479
if (!ReadEqualsSign(input, ref offset))
480480
{
481-
result.SameSite = UseSameSite2016Compat ? SameSiteMode.Strict : (SameSiteMode)(-1); // Unspecified
481+
result.SameSite = SuppressSameSiteNone ? SameSiteMode.Strict : (SameSiteMode)(-1); // Unspecified
482482
}
483483
else
484484
{
@@ -492,14 +492,14 @@ private static int GetSetCookieLength(StringSegment input, int startIndex, out S
492492
{
493493
result.SameSite = SameSiteMode.Lax;
494494
}
495-
else if (!UseSameSite2016Compat
495+
else if (!SuppressSameSiteNone
496496
&& StringSegment.Equals(enforcementMode, SameSiteNoneToken, StringComparison.OrdinalIgnoreCase))
497497
{
498498
result.SameSite = SameSiteMode.None;
499499
}
500500
else
501501
{
502-
result.SameSite = UseSameSite2016Compat ? SameSiteMode.Strict : (SameSiteMode)(-1); // Unspecified
502+
result.SameSite = SuppressSameSiteNone ? SameSiteMode.Strict : (SameSiteMode)(-1); // Unspecified
503503
}
504504
}
505505
}

‎src/Http/Headers/test/SetCookieHeaderValueTest.cs

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -314,9 +314,9 @@ public void SetCookieHeaderValue_ToString(SetCookieHeaderValue input, string exp
314314
}
315315

316316
[Fact]
317-
public void SetCookieHeaderValue_ToString_SameSite2016Compat()
317+
public void SetCookieHeaderValue_ToString_SameSiteNoneCompat()
318318
{
319-
SetCookieHeaderValue.UseSameSite2016Compat = true;
319+
SetCookieHeaderValue.SuppressSameSiteNone = true;
320320

321321
var input = new SetCookieHeaderValue("name", "value")
322322
{
@@ -325,7 +325,7 @@ public void SetCookieHeaderValue_ToString_SameSite2016Compat()
325325

326326
Assert.Equal("name=value", input.ToString());
327327

328-
SetCookieHeaderValue.UseSameSite2016Compat = false;
328+
SetCookieHeaderValue.SuppressSameSiteNone = false;
329329

330330
var input2 = new SetCookieHeaderValue("name", "value")
331331
{
@@ -347,9 +347,9 @@ public void SetCookieHeaderValue_AppendToStringBuilder(SetCookieHeaderValue inpu
347347
}
348348

349349
[Fact]
350-
public void SetCookieHeaderValue_AppendToStringBuilder_SameSite2016Compat()
350+
public void SetCookieHeaderValue_AppendToStringBuilder_SameSiteNoneCompat()
351351
{
352-
SetCookieHeaderValue.UseSameSite2016Compat = true;
352+
SetCookieHeaderValue.SuppressSameSiteNone = true;
353353

354354
var builder = new StringBuilder();
355355
var input = new SetCookieHeaderValue("name", "value")
@@ -360,7 +360,7 @@ public void SetCookieHeaderValue_AppendToStringBuilder_SameSite2016Compat()
360360
input.AppendToStringBuilder(builder);
361361
Assert.Equal("name=value", builder.ToString());
362362

363-
SetCookieHeaderValue.UseSameSite2016Compat = false;
363+
SetCookieHeaderValue.SuppressSameSiteNone = false;
364364

365365
var builder2 = new StringBuilder();
366366
var input2 = new SetCookieHeaderValue("name", "value")
@@ -383,9 +383,9 @@ public void SetCookieHeaderValue_Parse_AcceptsValidValues(SetCookieHeaderValue c
383383
}
384384

385385
[Fact]
386-
public void SetCookieHeaderValue_Parse_AcceptsValidValues_SameSite2016Compat()
386+
public void SetCookieHeaderValue_Parse_AcceptsValidValues_SameSiteNoneCompat()
387387
{
388-
SetCookieHeaderValue.UseSameSite2016Compat = true;
388+
SetCookieHeaderValue.SuppressSameSiteNone = true;
389389
var header = SetCookieHeaderValue.Parse("name=value; samesite=none");
390390

391391
var cookie = new SetCookieHeaderValue("name", "value")
@@ -395,7 +395,7 @@ public void SetCookieHeaderValue_Parse_AcceptsValidValues_SameSite2016Compat()
395395

396396
Assert.Equal(cookie, header);
397397
Assert.Equal("name=value; samesite=strict", header.ToString());
398-
SetCookieHeaderValue.UseSameSite2016Compat = false;
398+
SetCookieHeaderValue.SuppressSameSiteNone = false;
399399

400400
var header2 = SetCookieHeaderValue.Parse("name=value; samesite=none");
401401

@@ -418,9 +418,9 @@ public void SetCookieHeaderValue_TryParse_AcceptsValidValues(SetCookieHeaderValu
418418
}
419419

420420
[Fact]
421-
public void SetCookieHeaderValue_TryParse_AcceptsValidValues_SameSite2016Compat()
421+
public void SetCookieHeaderValue_TryParse_AcceptsValidValues_SameSiteNoneCompat()
422422
{
423-
SetCookieHeaderValue.UseSameSite2016Compat = true;
423+
SetCookieHeaderValue.SuppressSameSiteNone = true;
424424
Assert.True(SetCookieHeaderValue.TryParse("name=value; samesite=none", out var header));
425425
var cookie = new SetCookieHeaderValue("name", "value")
426426
{
@@ -430,7 +430,7 @@ public void SetCookieHeaderValue_TryParse_AcceptsValidValues_SameSite2016Compat(
430430
Assert.Equal(cookie, header);
431431
Assert.Equal("name=value; samesite=strict", header.ToString());
432432

433-
SetCookieHeaderValue.UseSameSite2016Compat = false;
433+
SetCookieHeaderValue.SuppressSameSiteNone = false;
434434

435435
Assert.True(SetCookieHeaderValue.TryParse("name=value; samesite=none", out var header2));
436436
var cookie2 = new SetCookieHeaderValue("name", "value")

0 commit comments

Comments
 (0)