Renames

Author: jkotalik

src/Servers/Kestrel/Core/src/Internal/Http/Http1OutputProducer.cs

@@ -49,7 +49,7 @@ public class Http1OutputProducer : IHttpOutputProducer, IHttpOutputAborter, IDis
         private int _advancedBytesForChunk;
         private Memory<byte> _currentChunkMemory;
         private bool _currentChunkMemoryUpdated;
-        private IMemoryOwner<byte> _completedMemoryOwner;
+        private IMemoryOwner<byte> _fakeMemoryOwner;
 
         public Http1OutputProducer(
             PipeWriter pipeWriter,
@@ -230,19 +230,24 @@ public void Dispose()
         {
             lock (_contextLock)
             {
-                if (_completedMemoryOwner != null)
+                if (_fakeMemoryOwner != null)
                 {
-                    _completedMemoryOwner.Dispose();
-                    _completedMemoryOwner = null;
+                    _fakeMemoryOwner.Dispose();
+                    _fakeMemoryOwner = null;
                 }
 
-                if (!_pipeWriterCompleted)
-                {
-                    _log.ConnectionDisconnect(_connectionId);
-                    _pipeWriterCompleted = true;
-                    _completed = true;
-                    _pipeWriter.Complete();
-                }
+                CompletePipe();
+            }
+        }
+
+        private void CompletePipe()
+        {
+            if (!_pipeWriterCompleted)
+            {
+                _log.ConnectionDisconnect(_connectionId);
+                _pipeWriterCompleted = true;
+                _completed = true;
+                _pipeWriter.Complete();
             }
         }
 
@@ -259,7 +264,8 @@ public void Abort(ConnectionAbortedException error)
 
                 _aborted = true;
                 _connectionContext.Abort(error);
-                Dispose();
+
+                CompletePipe();
             }
         }
 
@@ -379,11 +385,11 @@ private void WriteCurrentMemoryToPipeWriter()
 
         private Memory<byte> GetFakeMemory(int sizeHint)
         {
-            if (_completedMemoryOwner == null)
+            if (_fakeMemoryOwner == null)
             {
-                _completedMemoryOwner = _memoryPool.Rent(sizeHint);
+                _fakeMemoryOwner = _memoryPool.Rent(sizeHint);
             }
-            return _completedMemoryOwner.Memory;
+            return _fakeMemoryOwner.Memory;
         }
     }
 }

src/Servers/Kestrel/Core/src/Internal/Http2/Http2OutputProducer.cs

@@ -260,7 +260,7 @@ ValueTask<FlushResult> IHttpOutputProducer.WriteChunkAsync(ReadOnlySpan<byte> da
 
         public void Complete()
         {
-            // This will noop for now. See: 
+            // This will noop for now. See: https://github.com/aspnet/AspNetCore/issues/7370
         }
 
         private async ValueTask<FlushResult> ProcessDataWrites()