Use ModelOnly for Validation Summary (#6108)

Previously when Validation Summary used "All", it would append the property-related content to both the summary as well as the property specific span elements (= asp-validation-for="...").

By switching to ModelOnly would only show model-related messages in the summary (such as "Invalid login attempt.") which was most likely the original intention.

Author: nj

src/Identity/UI/src/Areas/Identity/Pages/V3/Account/ExternalLogin.cshtml

@@ -17,7 +17,7 @@
 <div class="row">
     <div class="col-md-4">
         <form asp-page-handler="Confirmation" asp-route-returnUrl="@Model.ReturnUrl" method="post">
-            <div asp-validation-summary="All" class="text-danger"></div>
+            <div asp-validation-summary="ModelOnly" class="text-danger"></div>
             <div class="form-group">
                 <label asp-for="Input.Email"></label>
                 <input asp-for="Input.Email" class="form-control" />

src/Identity/UI/src/Areas/Identity/Pages/V3/Account/ForgotPassword.cshtml

@@ -10,7 +10,7 @@
 <div class="row">
     <div class="col-md-4">
         <form method="post">
-            <div asp-validation-summary="All" class="text-danger"></div>
+            <div asp-validation-summary="ModelOnly" class="text-danger"></div>
             <div class="form-group">
                 <label asp-for="Input.Email"></label>
                 <input asp-for="Input.Email" class="form-control" />

src/Identity/UI/src/Areas/Identity/Pages/V3/Account/Login.cshtml

@@ -12,7 +12,7 @@
             <form id="account" method="post">
                 <h4>Use a local account to log in.</h4>
                 <hr />
-                <div asp-validation-summary="All" class="text-danger"></div>
+                <div asp-validation-summary="ModelOnly" class="text-danger"></div>
                 <div class="form-group">
                     <label asp-for="Input.Email"></label>
                     <input asp-for="Input.Email" class="form-control" />

src/Identity/UI/src/Areas/Identity/Pages/V3/Account/LoginWith2fa.cshtml

@@ -11,7 +11,7 @@
     <div class="col-md-4">
         <form method="post" asp-route-returnUrl="@Model.ReturnUrl">
             <input asp-for="RememberMe" type="hidden" />
-            <div asp-validation-summary="All" class="text-danger"></div>
+            <div asp-validation-summary="ModelOnly" class="text-danger"></div>
             <div class="form-group">
                 <label asp-for="Input.TwoFactorCode"></label>
                 <input asp-for="Input.TwoFactorCode" class="form-control" autocomplete="off" />

src/Identity/UI/src/Areas/Identity/Pages/V3/Account/LoginWithRecoveryCode.cshtml

@@ -13,7 +13,7 @@
 <div class="row">
     <div class="col-md-4">
         <form method="post">
-            <div asp-validation-summary="All" class="text-danger"></div>
+            <div asp-validation-summary="ModelOnly" class="text-danger"></div>
             <div class="form-group">
                 <label asp-for="Input.RecoveryCode"></label>
                 <input asp-for="Input.RecoveryCode" class="form-control" autocomplete="off" />

src/Identity/UI/src/Areas/Identity/Pages/V3/Account/Manage/ChangePassword.cshtml

@@ -10,7 +10,7 @@
 <div class="row">
     <div class="col-md-6">
         <form id="change-password-form" method="post">
-            <div asp-validation-summary="All" class="text-danger"></div>
+            <div asp-validation-summary="ModelOnly" class="text-danger"></div>
             <div class="form-group">
                 <label asp-for="Input.OldPassword"></label>
                 <input asp-for="Input.OldPassword" class="form-control" />

src/Identity/UI/src/Areas/Identity/Pages/V3/Account/Manage/DeletePersonalData.cshtml

@@ -16,7 +16,7 @@
 
 <div>
     <form id="delete-user" method="post" class="form-group">
-        <div asp-validation-summary="All" class="text-danger"></div>
+        <div asp-validation-summary="ModelOnly" class="text-danger"></div>
         @if (Model.RequirePassword)
         {
             <div class="form-group">

src/Identity/UI/src/Areas/Identity/Pages/V3/Account/Manage/Index.cshtml

@@ -10,7 +10,7 @@
 <div class="row">
     <div class="col-md-6">
         <form id="profile-form" method="post">
-            <div asp-validation-summary="All" class="text-danger"></div>
+            <div asp-validation-summary="ModelOnly" class="text-danger"></div>
             <div class="form-group">
                 <label asp-for="Username"></label>
                 <input asp-for="Username" class="form-control" disabled />

src/Identity/UI/src/Areas/Identity/Pages/V3/Account/Manage/SetPassword.cshtml

@@ -14,7 +14,7 @@
 <div class="row">
     <div class="col-md-6">
         <form id="set-password-form" method="post">
-            <div asp-validation-summary="All" class="text-danger"></div>
+            <div asp-validation-summary="ModelOnly" class="text-danger"></div>
             <div class="form-group">
                 <label asp-for="Input.NewPassword"></label>
                 <input asp-for="Input.NewPassword" class="form-control" />

src/Identity/UI/src/Areas/Identity/Pages/V3/Account/Register.cshtml

@@ -11,7 +11,7 @@
         <form id="registerForm" asp-route-returnUrl="@Model.ReturnUrl" method="post">
             <h4>Create a new account.</h4>
             <hr />
-            <div asp-validation-summary="All" class="text-danger"></div>
+            <div asp-validation-summary="ModelOnly" class="text-danger"></div>
             <div class="form-group">
                 <label asp-for="Input.Email"></label>
                 <input asp-for="Input.Email" class="form-control" />

src/Identity/UI/src/Areas/Identity/Pages/V3/Account/ResetPassword.cshtml

@@ -10,7 +10,7 @@
 <div class="row">
     <div class="col-md-4">
         <form method="post">
-            <div asp-validation-summary="All" class="text-danger"></div>
+            <div asp-validation-summary="ModelOnly" class="text-danger"></div>
             <input asp-for="Input.Code" type="hidden" />
             <div class="form-group">
                 <label asp-for="Input.Email"></label>

src/Identity/UI/src/Areas/Identity/Pages/V4/Account/ExternalLogin.cshtml

@@ -17,7 +17,7 @@
 <div class="row">
     <div class="col-md-4">
         <form asp-page-handler="Confirmation" asp-route-returnUrl="@Model.ReturnUrl" method="post">
-            <div asp-validation-summary="All" class="text-danger"></div>
+            <div asp-validation-summary="ModelOnly" class="text-danger"></div>
             <div class="form-group">
                 <label asp-for="Input.Email"></label>
                 <input asp-for="Input.Email" class="form-control" />

src/Identity/UI/src/Areas/Identity/Pages/V4/Account/ForgotPassword.cshtml

@@ -10,7 +10,7 @@
 <div class="row">
     <div class="col-md-4">
         <form method="post">
-            <div asp-validation-summary="All" class="text-danger"></div>
+            <div asp-validation-summary="ModelOnly" class="text-danger"></div>
             <div class="form-group">
                 <label asp-for="Input.Email"></label>
                 <input asp-for="Input.Email" class="form-control" />

src/Identity/UI/src/Areas/Identity/Pages/V4/Account/Login.cshtml

@@ -12,7 +12,7 @@
             <form id="account" method="post">
                 <h4>Use a local account to log in.</h4>
                 <hr />
-                <div asp-validation-summary="All" class="text-danger"></div>
+                <div asp-validation-summary="ModelOnly" class="text-danger"></div>
                 <div class="form-group">
                     <label asp-for="Input.Email"></label>
                     <input asp-for="Input.Email" class="form-control" />

src/Identity/UI/src/Areas/Identity/Pages/V4/Account/LoginWith2fa.cshtml

@@ -11,7 +11,7 @@
     <div class="col-md-4">
         <form method="post" asp-route-returnUrl="@Model.ReturnUrl">
             <input asp-for="RememberMe" type="hidden" />
-            <div asp-validation-summary="All" class="text-danger"></div>
+            <div asp-validation-summary="ModelOnly" class="text-danger"></div>
             <div class="form-group">
                 <label asp-for="Input.TwoFactorCode"></label>
                 <input asp-for="Input.TwoFactorCode" class="form-control" autocomplete="off" />

src/Identity/UI/src/Areas/Identity/Pages/V4/Account/LoginWithRecoveryCode.cshtml

@@ -13,7 +13,7 @@
 <div class="row">
     <div class="col-md-4">
         <form method="post">
-            <div asp-validation-summary="All" class="text-danger"></div>
+            <div asp-validation-summary="ModelOnly" class="text-danger"></div>
             <div class="form-group">
                 <label asp-for="Input.RecoveryCode"></label>
                 <input asp-for="Input.RecoveryCode" class="form-control" autocomplete="off" />

src/Identity/UI/src/Areas/Identity/Pages/V4/Account/Manage/ChangePassword.cshtml

@@ -10,7 +10,7 @@
 <div class="row">
     <div class="col-md-6">
         <form id="change-password-form" method="post">
-            <div asp-validation-summary="All" class="text-danger"></div>
+            <div asp-validation-summary="ModelOnly" class="text-danger"></div>
             <div class="form-group">
                 <label asp-for="Input.OldPassword"></label>
                 <input asp-for="Input.OldPassword" class="form-control" />

src/Identity/UI/src/Areas/Identity/Pages/V4/Account/Manage/DeletePersonalData.cshtml

@@ -15,7 +15,7 @@
 
 <div>
     <form id="delete-user" method="post" class="form-group">
-        <div asp-validation-summary="All" class="text-danger"></div>
+        <div asp-validation-summary="ModelOnly" class="text-danger"></div>
         @if (Model.RequirePassword)
         {
             <div class="form-group">

src/Identity/UI/src/Areas/Identity/Pages/V4/Account/Manage/Index.cshtml

@@ -10,7 +10,7 @@
 <div class="row">
     <div class="col-md-6">
         <form id="profile-form" method="post">
-            <div asp-validation-summary="All" class="text-danger"></div>
+            <div asp-validation-summary="ModelOnly" class="text-danger"></div>
             <div class="form-group">
                 <label asp-for="Username"></label>
                 <input asp-for="Username" class="form-control" disabled />

src/Identity/UI/src/Areas/Identity/Pages/V4/Account/Manage/SetPassword.cshtml

@@ -14,7 +14,7 @@
 <div class="row">
     <div class="col-md-6">
         <form id="set-password-form" method="post">
-            <div asp-validation-summary="All" class="text-danger"></div>
+            <div asp-validation-summary="ModelOnly" class="text-danger"></div>
             <div class="form-group">
                 <label asp-for="Input.NewPassword"></label>
                 <input asp-for="Input.NewPassword" class="form-control" />

src/Identity/UI/src/Areas/Identity/Pages/V4/Account/Register.cshtml

@@ -11,7 +11,7 @@
         <form id="registerForm" asp-route-returnUrl="@Model.ReturnUrl" method="post">
             <h4>Create a new account.</h4>
             <hr />
-            <div asp-validation-summary="All" class="text-danger"></div>
+            <div asp-validation-summary="ModelOnly" class="text-danger"></div>
             <div class="form-group">
                 <label asp-for="Input.Email"></label>
                 <input asp-for="Input.Email" class="form-control" />

src/Identity/UI/src/Areas/Identity/Pages/V4/Account/ResetPassword.cshtml

@@ -10,7 +10,7 @@
 <div class="row">
     <div class="col-md-4">
         <form method="post">
-            <div asp-validation-summary="All" class="text-danger"></div>
+            <div asp-validation-summary="ModelOnly" class="text-danger"></div>
             <input asp-for="Input.Code" type="hidden" />
             <div class="form-group">
                 <label asp-for="Input.Email"></label>

src/Identity/samples/IdentitySample.DefaultUI/Areas/Identity/Pages/Account/Manage/Index.cshtml

@@ -9,7 +9,7 @@
 <div class="row">
     <div class="col-md-6">
         <form method="post">
-            <div asp-validation-summary="All" class="text-danger"></div>
+            <div asp-validation-summary="ModelOnly" class="text-danger"></div>
             <div class="form-group">
                 <label asp-for="Username"></label>
                 <input asp-for="Username" class="form-control" disabled />

src/Identity/samples/IdentitySample.DefaultUI/Areas/Identity/Pages/Account/Register.cshtml

@@ -11,7 +11,7 @@
         <form asp-route-returnUrl="@Model.ReturnUrl" method="post">
             <h4>Create a new account.</h4>
             <hr />
-            <div asp-validation-summary="All" class="text-danger"></div>
+            <div asp-validation-summary="ModelOnly" class="text-danger"></div>
             <div class="form-group">
                 <label asp-for="Input.Email"></label>
                 <input asp-for="Input.Email" class="form-control" />

src/Identity/samples/IdentitySample.Mvc/Views/Account/ExternalLoginConfirmation.cshtml

@@ -9,7 +9,7 @@
 <form asp-controller="Account" asp-action="ExternalLoginConfirmation" asp-route-returnurl="@ViewData["ReturnUrl"]" method="post" class="form-horizontal" role="form">
     <h4>Association Form</h4>
     <hr />
-    <div asp-validation-summary="All" class="text-danger"></div>
+    <div asp-validation-summary="ModelOnly" class="text-danger"></div>
 
     <p class="text-info">
         You've successfully authenticated with <strong>@ViewData["ProviderDisplayName"]</strong>.

src/Identity/samples/IdentitySample.Mvc/Views/Account/ForgotPassword.cshtml

@@ -11,7 +11,7 @@
 @*<form asp-controller="Account" asp-action="ForgotPassword" method="post" class="form-horizontal" role="form">
     <h4>Enter your email.</h4>
     <hr />
-    <div asp-validation-summary="All" class="text-danger"></div>
+    <div asp-validation-summary="ModelOnly" class="text-danger"></div>
     <div class="form-group">
         <label asp-for="Email" class="col-md-2 control-label"></label>
         <div class="col-md-10">

src/Identity/samples/IdentitySample.Mvc/Views/Account/Login.cshtml

@@ -15,7 +15,7 @@
             <form asp-controller="Account" asp-action="Login" asp-route-returnurl="@ViewData["ReturnUrl"]" method="post" class="form-horizontal" role="form">
                 <h4>Use a local account to log in.</h4>
                 <hr />
-                <div asp-validation-summary="All" class="text-danger"></div>
+                <div asp-validation-summary="ModelOnly" class="text-danger"></div>
                 <div class="form-group">
                     <label asp-for="Email" class="col-md-2 control-label"></label>
                     <div class="col-md-10">

src/Identity/samples/IdentitySample.Mvc/Views/Account/Register.cshtml

@@ -8,7 +8,7 @@
 <form asp-controller="Account" asp-action="Register" asp-route-returnurl="@ViewData["ReturnUrl"]" method="post" class="form-horizontal" role="form">
     <h4>Create a new account.</h4>
     <hr />
-    <div asp-validation-summary="All" class="text-danger"></div>
+    <div asp-validation-summary="ModelOnly" class="text-danger"></div>
     <div class="form-group">
         <label asp-for="Email" class="col-md-2 control-label"></label>
         <div class="col-md-10">

src/Identity/samples/IdentitySample.Mvc/Views/Account/ResetPassword.cshtml

@@ -8,7 +8,7 @@
 <form asp-controller="Account" asp-action="ResetPassword" method="post" class="form-horizontal" role="form">
     <h4>Reset your password.</h4>
     <hr />
-    <div asp-validation-summary="All" class="text-danger"></div>
+    <div asp-validation-summary="ModelOnly" class="text-danger"></div>
     <input asp-for="Code" type="hidden" />
     <div class="form-group">
         <label asp-for="Email" class="col-md-2 control-label"></label>

src/Identity/samples/IdentitySample.Mvc/Views/Account/UseRecoveryCode.cshtml

@@ -6,7 +6,7 @@
 <h1>@ViewData["Title"].</h1>
 
 <form asp-controller="Account" asp-action="UseRecoveryCode" asp-route-returnurl="@ViewData["ReturnUrl"]" method="post" class="form-horizontal" role="form">
-    <div asp-validation-summary="All" class="text-danger"></div>
+    <div asp-validation-summary="ModelOnly" class="text-danger"></div>
     <h4>@ViewData["Status"]</h4>
     <hr />
     <div class="form-group">

src/Identity/samples/IdentitySample.Mvc/Views/Account/VerifyAuthenticatorCode.cshtml

@@ -6,7 +6,7 @@
 <h1>@ViewData["Title"].</h1>
 
 <form asp-controller="Account" asp-action="VerifyAuthenticatorCode" asp-route-returnurl="@ViewData["ReturnUrl"]" method="post" class="form-horizontal" role="form">
-    <div asp-validation-summary="All" class="text-danger"></div>
+    <div asp-validation-summary="ModelOnly" class="text-danger"></div>
     <input asp-for="RememberMe" type="hidden" />
     <h4>@ViewData["Status"]</h4>
     <hr />

src/Identity/samples/IdentitySample.Mvc/Views/Account/VerifyCode.cshtml

@@ -6,7 +6,7 @@
 <h1>@ViewData["Title"].</h1>
 
 <form asp-controller="Account" asp-action="VerifyCode" asp-route-returnurl="@ViewData["ReturnUrl"]" method="post" class="form-horizontal" role="form">
-    <div asp-validation-summary="All" class="text-danger"></div>
+    <div asp-validation-summary="ModelOnly" class="text-danger"></div>
     <input asp-for="Provider" type="hidden" />
     <input asp-for="RememberMe" type="hidden" />
     <h4>@ViewData["Status"]</h4>

src/Identity/samples/IdentitySample.Mvc/Views/Manage/AddPhoneNumber.cshtml

@@ -7,7 +7,7 @@
 <form asp-controller="Manage" asp-action="AddPhoneNumber" method="post" class="form-horizontal" role="form">
     <h4>Add a phone number.</h4>
     <hr />
-    <div asp-validation-summary="All" class="text-danger"></div>
+    <div asp-validation-summary="ModelOnly" class="text-danger"></div>
     <div class="form-group">
         <label asp-for="PhoneNumber" class="col-md-2 control-label"></label>
         <div class="col-md-10">

src/Identity/samples/IdentitySample.Mvc/Views/Manage/ChangePassword.cshtml

@@ -8,7 +8,7 @@
 <form asp-controller="Manage" asp-action="ChangePassword" method="post" class="form-horizontal" role="form">
     <h4>Change Password Form</h4>
     <hr />
-    <div asp-validation-summary="All" class="text-danger"></div>
+    <div asp-validation-summary="ModelOnly" class="text-danger"></div>
     <div class="form-group">
         <label asp-for="OldPassword" class="col-md-2 control-label"></label>
         <div class="col-md-10">

src/Identity/samples/IdentitySample.Mvc/Views/Manage/SetPassword.cshtml

@@ -11,7 +11,7 @@
 <form asp-controller="Manage" asp-action="SetPassword" asp-route-returnurl="@ViewData["ReturnUrl"]" method="post" class="form-horizontal" role="form">
     <h4>Set your password</h4>
     <hr />
-    <div asp-validation-summary="All" class="text-danger"></div>
+    <div asp-validation-summary="ModelOnly" class="text-danger"></div>
     <div class="form-group">
         <label asp-for="NewPassword" class="col-md-2 control-label"></label>
         <div class="col-md-10">

src/Identity/samples/IdentitySample.Mvc/Views/Manage/VerifyPhoneNumber.cshtml

@@ -10,7 +10,7 @@
     <h4>Add a phone number.</h4>
     <h5>@ViewData["Status"]</h5>
     <hr />
-    <div asp-validation-summary="All" class="text-danger"></div>
+    <div asp-validation-summary="ModelOnly" class="text-danger"></div>
     <div class="form-group">
         <label asp-for="Code" class="col-md-2 control-label"></label>
         <div class="col-md-10">

src/Identity/testassets/Identity.DefaultUI.WebSite/Pages/Contoso/Login.cshtml

@@ -10,7 +10,7 @@
     <div class="col-md-4">
         <section>
             <form id="external-login" method="post">
-                <div asp-validation-summary="All" class="text-danger"></div>
+                <div asp-validation-summary="ModelOnly" class="text-danger"></div>
                 <div class="form-group">
                     <label asp-for="Input.Login"></label>
                     <input asp-for="Input.Login" class="form-control" />