adjust functional test name and better isolate sample changes

latonz · latonz · commit 247a94855c6c · 2024-07-18T20:00:04.000-05:00
diff --git a/src/Middleware/Diagnostics/test/FunctionalTests/ProblemDetailsExceptionHandlerSampleTest.cs b/src/Middleware/Diagnostics/test/FunctionalTests/ProblemDetailsExceptionHandlerSampleTest.cs
@@ -37,10 +37,10 @@ public async Task ExceptionHandlerPage_ProducesProblemDetails()
     }
 
     [Fact]
-    public async Task StatusCodeSelector_ProducesProblemDetailsWith403()
+    public async Task StatusCodeSelector_ProducesProblemDetailsWithCustomStatusCode()
     {
         // Arrange
-        var request = new HttpRequestMessage(HttpMethod.Get, "http://localhost/throw/conflict");
+        var request = new HttpRequestMessage(HttpMethod.Get, "http://localhost/throw2/conflict");
         request.Headers.Accept.Add(new MediaTypeWithQualityHeaderValue("application/json"));
 
         // Act
diff --git a/src/Middleware/Diagnostics/test/testassets/ExceptionHandlerSample/StartupWithProblemDetails.cs b/src/Middleware/Diagnostics/test/testassets/ExceptionHandlerSample/StartupWithProblemDetails.cs
@@ -16,23 +16,28 @@ public void ConfigureServices(IServiceCollection services)
 
     public void Configure(IApplicationBuilder app)
     {
-        // Configure the error handler to produces a ProblemDetails.
-        app.UseExceptionHandler(new ExceptionHandlerOptions
+        // The broken section of our application.
+        app.Map("/throw", throwApp =>
         {
-            StatusCodeSelector = ex => ex is ConflictException
-                ? StatusCodes.Status409Conflict
-                : StatusCodes.Status500InternalServerError,
+            // Configure the error handler to produce ProblemDetails.
+            throwApp.UseExceptionHandler();
+            throwApp.Run(_ => throw new Exception("Application Exception"));
         });
 
-        // The broken section of our application.
-        app.Map("/throw", throwApp =>
+        app.Map("/throw2", throwApp =>
         {
+            // Configure the error handler to produce ProblemDetails with a mapped status code
+            throwApp.UseExceptionHandler(new ExceptionHandlerOptions
+            {
+                StatusCodeSelector = ex => ex is ConflictException
+                    ? StatusCodes.Status409Conflict
+                    : StatusCodes.Status500InternalServerError,
+            });
+
             throwApp.Map("/conflict", throwConflictApp =>
             {
                 throwConflictApp.Run(_ => throw new ConflictException("Conflict Exception"));
             });
-
-            throwApp.Run(_ => throw new Exception("Application Exception"));
         });
 
         app.UseStaticFiles();
@@ -43,7 +48,7 @@ public void Configure(IApplicationBuilder app)
             context.Response.ContentType = "text/html";
             await context.Response.WriteAsync("<html><body>Welcome to the sample<br><br>\r\n");
             await context.Response.WriteAsync("Click here to throw an exception: <a href=\"/throw\">throw</a><br>\r\n");
-            await context.Response.WriteAsync("Click here to throw a conflict exception: <a href=\"/throw/conflict\">throw conflict</a>\r\n");
+            await context.Response.WriteAsync("Click here to throw a conflict exception: <a href=\"/throw2/conflict\">throw conflict</a>\r\n");
             await context.Response.WriteAsync("</body></html>\r\n");
         });
     }

Original file line number	Diff line number	Diff line change
`@@ -37,10 +37,10 @@ public async Task ExceptionHandlerPage_ProducesProblemDetails()`
`37`	`37`	`}`
`38`	`38`
`39`	`39`	`[Fact]`
`40`		`- public async Task StatusCodeSelector_ProducesProblemDetailsWith403()`
	`40`	`+ public async Task StatusCodeSelector_ProducesProblemDetailsWithCustomStatusCode()`
`41`	`41`	`{`
`42`	`42`	`// Arrange`
`43`		`- var request = new HttpRequestMessage(HttpMethod.Get, "http://localhost/throw/conflict");`
	`43`	`+ var request = new HttpRequestMessage(HttpMethod.Get, "http://localhost/throw2/conflict");`
`44`	`44`	`request.Headers.Accept.Add(new MediaTypeWithQualityHeaderValue("application/json"));`
`45`	`45`
`46`	`46`	`// Act`