PR feedback

Author: JamesNK

src/Servers/Kestrel/Core/src/Http2Limits.cs

@@ -141,15 +141,5 @@ public int InitialStreamWindowSize
                 _initialStreamWindowSize = value;
             }
         }
-
-        /// <summary>
-        /// Gets or sets a value that controls whether dynamic compression of response headers is allowed.
-        /// For more information about the security considerations of HPack dynamic header compression, visit
-        /// https://tools.ietf.org/html/rfc7541#section-7.
-        /// </summary>
-        /// <remarks>
-        /// Defaults to true.
-        /// </remarks>
-        public bool AllowResponseHeaderCompression { get; set; } = true;
     }
 }

src/Servers/Kestrel/Core/src/Internal/Http2/Http2FrameWriter.cs

@@ -71,7 +71,7 @@ public Http2FrameWriter(
             _outgoingFrame = new Http2Frame();
             _headerEncodingBuffer = new byte[_maxFrameSize];
 
-            _hpackEncoder = new HPackEncoder(!serviceContext.ServerOptions.Limits.Http2.AllowResponseHeaderCompression);
+            _hpackEncoder = new HPackEncoder(!serviceContext.ServerOptions.AllowResponseHeaderCompression);
         }
 
         public void UpdateMaxHeaderTableSize(uint maxHeaderTableSize)

src/Servers/Kestrel/Core/src/KestrelServerOptions.cs

@@ -38,6 +38,16 @@ public class KestrelServerOptions
         /// </remarks>
         public bool AddServerHeader { get; set; } = true;
 
+        /// <summary>
+        /// Gets or sets a value that controls whether dynamic compression of response headers is allowed.
+        /// For more information about the security considerations of HPack dynamic header compression, visit
+        /// https://tools.ietf.org/html/rfc7541#section-7.
+        /// </summary>
+        /// <remarks>
+        /// Defaults to true.
+        /// </remarks>
+        public bool AllowResponseHeaderCompression { get; set; } = true;
+
         /// <summary>
         /// Gets or sets a value that controls whether synchronous IO is allowed for the <see cref="HttpContext.Request"/> and <see cref="HttpContext.Response"/>
         /// </summary>

src/Servers/Kestrel/test/InMemory.FunctionalTests/Http2/Http2ConnectionTests.cs

@@ -2011,7 +2011,7 @@ public void OnStaticIndexedHeader(int index, ReadOnlySpan<byte> value)
         [Fact]
         public async Task HEADERS_DisableDynamicHeaderCompression_HeadersNotCompressed()
         {
-            _serviceContext.ServerOptions.Limits.Http2.AllowResponseHeaderCompression = false;
+            _serviceContext.ServerOptions.AllowResponseHeaderCompression = false;
 
             await InitializeConnectionAsync(_noopApplication);