More build issues

Author: jkotalik

src/Shared/Dictionary/SmallCapacityDictionary.cs

@@ -27,7 +27,7 @@ internal class SmallCapacityDictionary<TKey, TValue> : IDictionary<TKey, TValue>
         /// The new instance will take ownership of the array, and may mutate it.
         /// </summary>
         /// <param name="items">The items array.</param>
-        /// <param name="comparer"></param>
+        /// <param name="comparer">Equality comparison.</param>
         /// <returns>A new <see cref="SmallCapacityDictionary{TKey, TValue}"/>.</returns>
         public static SmallCapacityDictionary<TKey, TValue> FromArray(KeyValuePair<TKey, TValue>[] items, IEqualityComparer<TKey>? comparer = null)
         {
@@ -102,22 +102,29 @@ public SmallCapacityDictionary()
         {
         }
 
-        public SmallCapacityDictionary(Dictionary<TKey, TValue> dict)
-            : this(0, EqualityComparer<TKey>.Default)
-        {
-            _backup = dict;
-        }
-
+        /// <summary>
+        /// Creates a <see cref="SmallCapacityDictionary{TKey, TValue}"/>.
+        /// </summary>
+        /// <param name="comparer">Equality comparison.</param>
         public SmallCapacityDictionary(IEqualityComparer<TKey> comparer)
             : this(0, comparer)
         {
         }
 
+        /// <summary>
+        /// Creates a <see cref="SmallCapacityDictionary{TKey, TValue}"/>.
+        /// </summary>
+        /// <param name="capacity">Initial capacity.</param>
         public SmallCapacityDictionary(int capacity)
             : this(capacity, EqualityComparer<TKey>.Default)
         {
         }
 
+        /// <summary>
+        /// Creates a <see cref="SmallCapacityDictionary{TKey, TValue}"/>.
+        /// </summary>
+        /// <param name="capacity">Initial capacity.</param>
+        /// <param name="comparer">Equality comparison.</param>
         public SmallCapacityDictionary(int capacity, IEqualityComparer<TKey> comparer)
         {
             if (comparer is not null && comparer != EqualityComparer<TKey>.Default) // first check for null to avoid forcing default comparer instantiation unnecessarily
@@ -151,13 +158,9 @@ public SmallCapacityDictionary(int capacity, IEqualityComparer<TKey> comparer)
         /// <see cref="IDictionary{TKey, TValue}"/> or <see cref="IReadOnlyDictionary{TKey, TValue}"/>
         /// or an object with public properties as key-value pairs.
         /// </param>
-        /// <remarks>
-        /// If the value is a dictionary or other <see cref="IEnumerable{T}"/> of <see cref="KeyValuePair{String, Object}"/>,
-        /// then its entries are copied. Otherwise the object is interpreted as a set of key-value pairs where the
-        /// property names are keys, and property values are the values, and copied into the dictionary.
-        /// Only public instance non-index properties are considered.
-        /// </remarks>
-        public SmallCapacityDictionary(IEnumerable<KeyValuePair<TKey, TValue>> values, IEqualityComparer<TKey> comparer, int capacity)
+        /// <param name="comparer">Equality comparison.</param>
+        /// <param name="capacity">Initial capacity.</param>
+        public SmallCapacityDictionary(IEnumerable<KeyValuePair<TKey, TValue>> values, int capacity, IEqualityComparer<TKey> comparer)
         {
             _comparer = comparer ?? EqualityComparer<TKey>.Default;
 

src/Shared/test/Shared.Tests/SmallCapacityDictionaryTests.cs

@@ -30,7 +30,7 @@ public void CreateFromNull()
         {
             // Arrange
             // Act
-            var dict = new SmallCapacityDictionary<string, string>(dict: null);
+            var dict = new SmallCapacityDictionary<string, string>();
 
             // Assert
             Assert.Empty(dict);
@@ -89,7 +89,7 @@ public void CreateFromIEnumerableKeyValuePair_CopiesValues()
         public void CreateFromIEnumerableStringValuePair_CopiesValues()
         {
             // Arrange & Act
-            var dict = new SmallCapacityDictionary<string, string>(IEnumerableStringValuePairData, StringComparer.OrdinalIgnoreCase, capacity: 3);
+            var dict = new SmallCapacityDictionary<string, string>(IEnumerableStringValuePairData, capacity: 3, StringComparer.OrdinalIgnoreCase);
 
             // Assert
             Assert.IsType<KeyValuePair<string, string>[]>(dict._arrayStorage);
@@ -126,7 +126,7 @@ public void CreateFromIEnumerableStringValuePair_ThrowsExceptionForDuplicateKey(
 
             // Act & Assert
             ExceptionAssert.ThrowsArgument(
-                () => new SmallCapacityDictionary<string, string>(values, StringComparer.OrdinalIgnoreCase, capacity: 3),
+                () => new SmallCapacityDictionary<string, string>(values, capacity: 3, StringComparer.OrdinalIgnoreCase),
                 "key",
                 $"An element with the key 'Name' already exists in the {nameof(SmallCapacityDictionary<string, object>)}.");
         }