Skip to content

Commit 28678ee

Browse files
hishamcomkArtakMSFT
authored andcommitted
Change unsupported culture log level (#12153)
* Change unsupported culture log level to Debug * Fix unit tests
1 parent fad6a18 commit 28678ee

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

src/Middleware/Localization/src/RequestCultureProviderLoggerExtensions.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,11 +16,11 @@ internal static class RequestCultureProviderLoggerExtensions
1616
static RequestCultureProviderLoggerExtensions()
1717
{
1818
_unsupportedCulture = LoggerMessage.Define<string, IList<StringSegment>>(
19-
LogLevel.Warning,
19+
LogLevel.Debug,
2020
new EventId (1, "UnsupportedCulture"),
2121
"{requestCultureProvider} returned the following unsupported cultures '{cultures}'.");
2222
_unsupportedUICulture = LoggerMessage.Define<string, IList<StringSegment>>(
23-
LogLevel.Warning,
23+
LogLevel.Debug,
2424
new EventId(2, "UnsupportedUICulture"),
2525
"{requestCultureProvider} returned the following unsupported UI Cultures '{uiCultures}'.");
2626
}

src/Middleware/Localization/test/UnitTests/CookieRequestCultureProviderTest.cs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -147,7 +147,7 @@ public async Task GetDefaultCultureInfoIfCookieDoesNotExist()
147147
}
148148

149149
[Fact]
150-
public async Task RequestLocalizationMiddleware_LogsWarningsForUnsupportedCultures()
150+
public async Task RequestLocalizationMiddleware_LogsDebugForUnsupportedCultures()
151151
{
152152
var sink = new TestSink(
153153
TestSink.EnableWithTypeName<RequestLocalizationMiddleware>,
@@ -195,12 +195,12 @@ public async Task RequestLocalizationMiddleware_LogsWarningsForUnsupportedCultur
195195
var expectedMessage = $"{nameof(CookieRequestCultureProvider)} returned the following unsupported cultures '??'.";
196196

197197
var write = Assert.Single(sink.Writes);
198-
Assert.Equal(LogLevel.Warning, write.LogLevel);
198+
Assert.Equal(LogLevel.Debug, write.LogLevel);
199199
Assert.Equal(expectedMessage, write.State.ToString());
200200
}
201201

202202
[Fact]
203-
public async Task RequestLocalizationMiddleware_LogsWarningsForUnsupportedUICultures()
203+
public async Task RequestLocalizationMiddleware_LogsDebugForUnsupportedUICultures()
204204
{
205205
var sink = new TestSink(
206206
TestSink.EnableWithTypeName<RequestLocalizationMiddleware>,
@@ -247,7 +247,7 @@ public async Task RequestLocalizationMiddleware_LogsWarningsForUnsupportedUICult
247247

248248
var expectedMessage = $"{nameof(CookieRequestCultureProvider)} returned the following unsupported UI Cultures '??'.";
249249
var write = Assert.Single(sink.Writes);
250-
Assert.Equal(LogLevel.Warning, write.LogLevel);
250+
Assert.Equal(LogLevel.Debug, write.LogLevel);
251251
Assert.Equal(expectedMessage, write.State.ToString());
252252
}
253253
}

0 commit comments

Comments
 (0)